From 0945fd9b9c4bcb35964f1e67cdc45b1cac3f8621 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Tue, 19 Apr 2022 13:21:42 +0200
Subject: [PATCH] Initialize the pool before running queue or cron tasks

issue11400
review384981002
---
 trytond/cron.py   |  5 +++++
 trytond/worker.py | 28 ++++++++++++++++++----------
 2 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/trytond/cron.py b/trytond/cron.py
index 3308e91baf..4c3941d534 100644
--- a/trytond/cron.py
+++ b/trytond/cron.py
@@ -5,6 +5,7 @@ import threading
 import time
 
 from trytond.pool import Pool
+from trytond.transaction import Transaction
 
 __all__ = ['run']
 logger = logging.getLogger(__name__)
@@ -27,7 +28,11 @@ def run(options):
                 logger.info(
                     'skip "%s" as previous cron still running', db_name)
                 continue
+            database_list = Pool.database_list()
             pool = Pool(db_name)
+            if db_name not in database_list:
+                with Transaction().start(db_name, 0, readonly=True):
+                    pool.init()
             Cron = pool.get('ir.cron')
             thread = threading.Thread(
                     target=Cron.run,
diff --git a/trytond/worker.py b/trytond/worker.py
index 9f5a5cb91e..5ce8ef0db6 100644
--- a/trytond/worker.py
+++ b/trytond/worker.py
@@ -23,19 +23,22 @@ logger = logging.getLogger(__name__)
 
 
 class Queue(object):
-    def __init__(self, pool, mpool):
-        self.database = backend.Database(pool.database_name).connect()
+    def __init__(self, database_name, mpool):
+        self.database = backend.Database(database_name).connect()
         self.connection = self.database.get_connection(autocommit=True)
-        self.pool = pool
         self.mpool = mpool
 
     def pull(self, name=None):
-        Queue = self.pool.get('ir.queue')
+        database_list = Pool.database_list()
+        pool = Pool(self.database.name)
+        if self.database.name not in database_list:
+            with Transaction().start(self.database.name, 0, readonly=True):
+                pool.init()
+        Queue = pool.get('ir.queue')
         return Queue.pull(self.database, self.connection, name=name)
 
     def run(self, task_id):
-        return self.mpool.apply_async(
-            run_task, (self.pool.database_name, task_id))
+        return self.mpool.apply_async(run_task, (self.database.name, task_id))
 
 
 class TaskList(list):
@@ -56,8 +59,9 @@ def work(options):
         processes = 1
     logger.info("start %d workers", processes)
     mpool = MPool(
-        processes, initializer, (options,), options.maxtasksperchild)
-    queues = [Queue(pool, mpool) for pool in initializer(options, False)]
+        processes, initializer, (options.database_names,),
+        options.maxtasksperchild)
+    queues = [Queue(name, mpool) for name in options.database_names]
 
     tasks = TaskList()
     timeout = options.timeout
@@ -87,12 +91,12 @@ def work(options):
         selector.close()
 
 
-def initializer(options, worker=True):
+def initializer(database_names, worker=True):
     if worker:
         signal.signal(signal.SIGINT, signal.SIG_IGN)
     pools = []
     database_list = Pool.database_list()
-    for database_name in options.database_names:
+    for database_name in database_names:
         pool = Pool(database_name)
         if database_name not in database_list:
             with Transaction().start(database_name, 0, readonly=True):
@@ -103,7 +107,11 @@ def initializer(options, worker=True):
 
 def run_task(pool, task_id):
     if not isinstance(pool, Pool):
+        database_list = Pool.database_list()
         pool = Pool(pool)
+        if pool.database_name not in database_list:
+            with Transaction().start(pool.database_name, 0, readonly=True):
+                pool.init()
     Queue = pool.get('ir.queue')
     Error = pool.get('ir.error')
     name = '<Task %s@%s>' % (task_id, pool.database_name)