From 0d361542fe0c655d2afaa43b0d93f69673f83c22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Thu, 8 May 2025 18:36:13 +0200 Subject: [PATCH] Do not use state Function field of line to check against modification The Function field is an helper to write PYSON statement so there is no need to use it for checks. Closes #14002 --- modules/purchase/purchase.py | 2 +- modules/sale/sale.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/purchase/purchase.py b/modules/purchase/purchase.py index 0b7605ecce..2fdabd99b0 100644 --- a/modules/purchase/purchase.py +++ b/modules/purchase/purchase.py @@ -2125,7 +2125,7 @@ class Line(sequence_ordered(), ModelSQL, ModelView): purchase=line.purchase.rec_name)) elif mode == 'delete': for line in lines: - if line.purchase_state not in {'cancelled', 'draft'}: + if line.purchase.state not in {'cancelled', 'draft'}: raise AccessError(gettext( 'purchase.msg_purchase_line_delete_cancel_draft', line=line.rec_name, diff --git a/modules/sale/sale.py b/modules/sale/sale.py index 2f81e729d0..d59961cbf0 100644 --- a/modules/sale/sale.py +++ b/modules/sale/sale.py @@ -2258,7 +2258,7 @@ class SaleLine(TaxableMixin, sequence_ordered(), ModelSQL, ModelView): sale=line.sale.rec_name)) elif mode == 'delete': for line in lines: - if line.sale_state not in {'cancelled', 'draft'}: + if line.sale.state not in {'cancelled', 'draft'}: raise AccessError(gettext( 'sale.msg_sale_line_delete_cancel_draft', line=line.rec_name,