From 0d51fedc32e9d7eca7a1dcbd3767f227c2bdd998 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sat, 10 Apr 2021 23:46:24 +0200
Subject: [PATCH] Check rule only if _check_access is set and enforce companies
 rule

issue4080
review343891009
---
 sale.py                      |  5 ++++-
 sale.xml                     | 12 ++++++++++++
 tests/test_sale_gift_card.py |  4 +++-
 3 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/sale.py b/sale.py
index de63dd6db3..dbb2754426 100644
--- a/sale.py
+++ b/sale.py
@@ -69,7 +69,10 @@ class GiftCard(ModelSQL, ModelView):
         domain=[
             ('gift_card', '=', True),
             ],
-        states=_states, depends=_depends)
+        context={
+            'company': Eval('company', -1),
+            },
+        states=_states, depends=_depends + ['company'])
     value = fields.Numeric(
         "Value", digits=(16, Eval('currency_digits', 2)), required=True,
         states=_states, depends=_depends + ['currency_digits'])
diff --git a/sale.xml b/sale.xml
index f9c7bf5563..569487d8ab 100644
--- a/sale.xml
+++ b/sale.xml
@@ -93,6 +93,18 @@ this repository contains the full copyright notices and license terms. -->
             <field name="perm_delete" eval="True"/>
         </record>
 
+        <record model="ir.rule.group" id="rule_group_gift_card_companies">
+            <field name="name">User in companies</field>
+            <field name="model" search="[('model', '=', 'sale.gift_card')]"/>
+            <field name="global_p" eval="True"/>
+        </record>
+        <record model="ir.rule" id="rule_gift_card_companies">
+            <field name="domain"
+                eval="[('company', 'in', Eval('companies', []))]"
+                pyson="1"/>
+            <field name="rule_group" ref="rule_group_gift_card_companies"/>
+        </record>
+
         <record model="ir.action.report" id="report_gift_card_email">
             <field name="name">Gift Card</field>
             <field name="model">sale.gift_card</field>
diff --git a/tests/test_sale_gift_card.py b/tests/test_sale_gift_card.py
index 9903e8391a..e57739500a 100644
--- a/tests/test_sale_gift_card.py
+++ b/tests/test_sale_gift_card.py
@@ -10,8 +10,10 @@ from trytond.tests.test_tryton import suite as test_suite
 from trytond.tests.test_tryton import doctest_teardown
 from trytond.tests.test_tryton import doctest_checker
 
+from trytond.modules.company.tests import CompanyTestMixin
 
-class SaleGiftCardTestCase(ModuleTestCase):
+
+class SaleGiftCardTestCase(CompanyTestMixin, ModuleTestCase):
     'Test Sale Gift Card module'
     module = 'sale_gift_card'