From 0d5caa58e70b0652bbaafcf9576c5fab10fe63bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Thu, 30 Oct 2025 00:59:07 +0100 Subject: [PATCH] Use line's movable property to require incoterm Closes #14332 --- modules/incoterm/purchase.py | 2 +- modules/incoterm/sale.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/incoterm/purchase.py b/modules/incoterm/purchase.py index e87f90fbea..77d9a4323c 100644 --- a/modules/incoterm/purchase.py +++ b/modules/incoterm/purchase.py @@ -32,7 +32,7 @@ class Purchase(IncotermAvailableMixin, metaclass=PoolMeta): super().check_for_quotation() if not self.incoterm and self._incoterm_required: for line in self.lines: - if line.product and line.product.type in {'goods', 'assets'}: + if line.movable: raise PurchaseQuotationError( gettext('incoterm' '.msg_purchase_incoterm_required_for_quotation', diff --git a/modules/incoterm/sale.py b/modules/incoterm/sale.py index 96071230b5..2bd03d44f8 100644 --- a/modules/incoterm/sale.py +++ b/modules/incoterm/sale.py @@ -65,7 +65,7 @@ class Sale(IncotermAvailableMixin, metaclass=PoolMeta): super().check_for_quotation() if not self.incoterm and self._incoterm_required: for line in self.lines: - if line.product and line.product.type in {'goods', 'assets'}: + if line.movable: raise SaleQuotationError( gettext('incoterm' '.msg_sale_incoterm_required_for_quotation',