diff --git a/sale.py b/sale.py index a3cb47ffd3..ff609eac8d 100644 --- a/sale.py +++ b/sale.py @@ -1437,10 +1437,10 @@ class SaleLine(TaxableMixin, sequence_ordered(), ModelSQL, ModelView): @fields.depends('moves', methods=['planned_shipping_date']) def on_change_with_shipping_date(self, name=None): - if self.moves: + moves = [m for m in self.moves if m.state != 'cancelled'] + if moves: dates = filter( - None, (m.effective_date or m.planned_date for m in self.moves - if m.state != 'cancelled')) + None, (m.effective_date or m.planned_date for m in moves)) return min(dates, default=None) return self.planned_shipping_date