From 1c3a033e5f9bcd3a5d8f13b3d0eaaa8857880e1d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Tue, 31 May 2022 23:50:48 +0200
Subject: [PATCH] Test if value is not null before using its keys in
 set_on_change

issue11497
review421171003
---
 src/model.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/model.js b/src/model.js
index 80408e46ab..b5c938f937 100644
--- a/src/model.js
+++ b/src/model.js
@@ -2268,7 +2268,7 @@
                 return this._set_value(record, value, false, true);
             }
             var new_field_names = {};
-            if (value.add || value.update) {
+            if (value && (value.add || value.update)) {
                 var context = this.get_context(record);
                 fields = record._values[this.name].model.fields;
                 var adding_values = [];
@@ -2307,7 +2307,7 @@
             }
 
             var group = record._values[this.name];
-            if (value.delete) {
+            if (value && value.delete) {
                 for (const record_id of value.delete) {
                     const record2 = group.get(record_id);
                     if (record2) {
@@ -2315,7 +2315,7 @@
                     }
                 }
             }
-            if (value.remove) {
+            if (value && value.remove) {
                 for (const record_id of value.remove) {
                     const record2 = group.get(record_id);
                     if (record2) {
@@ -2324,7 +2324,7 @@
                 }
             }
 
-            if (value.add || value.update) {
+            if (value && (value.add || value.update)) {
                 // First set already added fields to prevent triggering a
                 // second on_change call
                 if (value.update) {