From 1f545e9cedd1c607d3aaa34c05ba4473ecb57797 Mon Sep 17 00:00:00 2001
From: Sergi Almacellas Abellana <sergi@koolpi.com>
Date: Mon, 19 Dec 2016 09:56:13 +0100
Subject: [PATCH] Fix antipatern of create/write in loop

issue3516
review14951002
---
 stock.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/stock.py b/stock.py
index 64508bf45d..0455227c8a 100644
--- a/stock.py
+++ b/stock.py
@@ -244,12 +244,15 @@ class ShipmentDrop(Workflow, ModelSQL, ModelView):
         Set planned date of moves for the shipments
         '''
         Move = Pool().get('stock.move')
+        to_write = []
         for shipment in shipments:
             planned_date = shipment._get_move_planned_date()
-            Move.write([m for m in shipment.moves
-                    if m.state not in ('assigned', 'done', 'cancel')], {
-                    'planned_date': planned_date,
-                    })
+            to_write.extend(([m for m in shipment.moves
+                        if m.state not in ('assigned', 'done', 'cancel')], {
+                        'planned_date': planned_date,
+                        }))
+        if to_write:
+            Move.write(*to_write)
 
     def get_moves(self, name):
         if name == 'supplier_moves':