From 245fe733dc3c093c1eb4136a16bbd69f3a694c04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20=C3=89vrard?= Date: Fri, 19 Sep 2014 23:32:48 +0200 Subject: [PATCH] Do not depend on the order of the lines in the reconciliation validation issue4163 review8551002 --- move.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/move.py b/move.py index a2cc7f98aa..536c90feb7 100644 --- a/move.py +++ b/move.py @@ -500,7 +500,8 @@ class Reconciliation(ModelSQL, ModelView): debit = Decimal('0.0') credit = Decimal('0.0') account = None - party = None + if reconciliation.lines: + party = reconciliation.lines[0].party for line in reconciliation.lines: if line.state != 'valid': cls.raise_user_error('reconciliation_line_not_valid', @@ -521,9 +522,7 @@ class Reconciliation(ModelSQL, ModelView): 'line': line.rec_name, 'account': line.account.rec_name, }) - if not party: - party = line.party - elif line.party and party.id != line.party.id: + if line.party != party: cls.raise_user_error('reconciliation_different_parties', { 'line': line.rec_name, 'party1': line.party.rec_name,