From 2e5089a5f646f206e1c150b4c4d5adf461f4a1aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Sat, 1 Sep 2018 01:02:04 +0200 Subject: [PATCH] Improve ModelStorage.copy * Allow callable in copy default * Support dotted notation in copy default * Use setdefault in copy * Copy default when needed * Do not set default state in copy * Use callable and dotted notation in copy default issue5576 issue7648 review72291002 --- sale.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sale.py b/sale.py index 9c9c1af7c1..926aa24bae 100644 --- a/sale.py +++ b/sale.py @@ -88,8 +88,9 @@ class SaleLine(metaclass=PoolMeta): def copy(cls, lines, default=None): if default is None: default = {} - default = default.copy() - default['purchase_request'] = None + else: + default = default.copy() + default.setdefault('purchase_request', None) return super(SaleLine, cls).copy(lines, default=default) @property