From 37f2a65721476516a66f7169bc136ee7d629c779 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 1 Mar 2020 12:33:51 +0100
Subject: [PATCH] Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
---
 .flake8           | 2 ++
 configuration.py  | 3 ---
 product.py        | 5 -----
 setup.py          | 7 ++++---
 tests/__init__.py | 2 +-
 5 files changed, 7 insertions(+), 12 deletions(-)
 create mode 100644 .flake8

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..bb03d08a82
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff --git a/configuration.py b/configuration.py
index b846215b47..1c6e533fe7 100644
--- a/configuration.py
+++ b/configuration.py
@@ -5,9 +5,6 @@ from trytond.model import fields
 from trytond.pyson import Eval
 
 
-__all__ = ['Configuration', 'ConfigurationDefaultAccount']
-
-
 class Configuration(metaclass=PoolMeta):
     __name__ = 'account.configuration'
 
diff --git a/product.py b/product.py
index 67c1e353db..0a03df8376 100644
--- a/product.py
+++ b/product.py
@@ -16,11 +16,6 @@ from trytond.modules.company.model import (
 
 from .exceptions import AccountError, TaxError
 
-__all__ = ['Category', 'CategoryAccount',
-    'CategoryCustomerTax', 'CategorySupplierTax',
-    'Template', 'Product', 'account_used', 'template_property',
-    'TemplateAccountCategory', 'TemplateCategoryAll']
-
 
 def account_used(field_name, field_string=None):
     if field_string is None:
diff --git a/setup.py b/setup.py
index 84acce6a98..f9acf90a43 100755
--- a/setup.py
+++ b/setup.py
@@ -79,8 +79,8 @@ setup(name=name,
     keywords='tryton account product',
     package_dir={'trytond.modules.account_product': '.'},
     packages=(
-        ['trytond.modules.account_product'] +
-        ['trytond.modules.account_product.%s' % p for p in find_packages()]
+        ['trytond.modules.account_product']
+        + ['trytond.modules.account_product.%s' % p for p in find_packages()]
         ),
     package_data={
         'trytond.modules.account_product': (info.get('xml', [])
@@ -93,7 +93,8 @@ setup(name=name,
         'Intended Audience :: Developers',
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',
diff --git a/tests/__init__.py b/tests/__init__.py
index 62199f82db..2f40c9fdf9 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.account_product.tests.test_account_product import suite
+    from trytond.modules.account_product.tests.test_account_product import suite  # noqa: E501
 except ImportError:
     from .test_account_product import suite