From 397e76eebef39d2f94ab21b6d28c100a8dd7fbdf Mon Sep 17 00:00:00 2001
From: Sergi Almacellas Abellana <sergi@koolpi.com>
Date: Thu, 1 Mar 2018 12:45:15 +0100
Subject: [PATCH] Register all buttons are registered in ir.model.button

issue6389
review36621002
---
 opportunity.xml           |  5 +++++
 view/opportunity_form.xml | 16 +++++-----------
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/opportunity.xml b/opportunity.xml
index 2e40b9cb82..8edb769988 100644
--- a/opportunity.xml
+++ b/opportunity.xml
@@ -149,6 +149,7 @@ this repository contains the full copyright notices and license terms. -->
 
         <record model="ir.model.button" id="opportunity_lead_button">
             <field name="name">lead</field>
+            <field name="string">Set as Lead</field>
             <field name="model" search="[('model', '=', 'sale.opportunity')]"/>
         </record>
         <record model="ir.model.button-res.group"
@@ -159,6 +160,7 @@ this repository contains the full copyright notices and license terms. -->
 
         <record model="ir.model.button" id="opportunity_opportunity_button">
             <field name="name">opportunity</field>
+            <field name="string">Convert to Opportunity</field>
             <field name="model" search="[('model', '=', 'sale.opportunity')]"/>
         </record>
         <record model="ir.model.button-res.group"
@@ -169,6 +171,7 @@ this repository contains the full copyright notices and license terms. -->
 
         <record model="ir.model.button" id="opportunity_convert_button">
             <field name="name">convert</field>
+            <field name="string">Convert to Sale</field>
             <field name="model" search="[('model', '=', 'sale.opportunity')]"/>
         </record>
         <record model="ir.model.button-res.group"
@@ -179,6 +182,7 @@ this repository contains the full copyright notices and license terms. -->
 
         <record model="ir.model.button" id="opportunity_lost_button">
             <field name="name">lost</field>
+            <field name="string">Mark as Lost</field>
             <field name="model" search="[('model', '=', 'sale.opportunity')]"/>
         </record>
         <record model="ir.model.button-res.group"
@@ -189,6 +193,7 @@ this repository contains the full copyright notices and license terms. -->
 
         <record model="ir.model.button" id="opportunity_cancel_button">
             <field name="name">cancel</field>
+            <field name="string">Cancel</field>
             <field name="model" search="[('model', '=', 'sale.opportunity')]"/>
         </record>
         <record model="ir.model.button-res.group"
diff --git a/view/opportunity_form.xml b/view/opportunity_form.xml
index 14b4fadb7e..1524ce46e6 100644
--- a/view/opportunity_form.xml
+++ b/view/opportunity_form.xml
@@ -44,17 +44,11 @@ this repository contains the full copyright notices and license terms. -->
                 <field name="state"/>
             </group>
             <group col="-1" colspan="2" id="buttons">
-                <button name="cancel" string="Cancel"
-                    icon="tryton-cancel"/>
-                <button name="lost" string="Mark as Lost"
-                    icon="tryton-cancel"/>
-                <button name="lead" string="Set as Lead"
-                    icon="tryton-go-previous"/>
-                <button name="opportunity"
-                    string="Convert to Opportunity"
-                    icon="tryton-go-next"/>
-                <button name="convert" string="Convert to Sale"
-                    icon="tryton-go-next"/>
+                <button name="cancel" icon="tryton-cancel"/>
+                <button name="lost" icon="tryton-cancel"/>
+                <button name="lead" icon="tryton-go-previous"/>
+                <button name="opportunity" icon="tryton-go-next"/>
+                <button name="convert" icon="tryton-go-next"/>
             </group>
         </page>
         <page name="lines">