From 3a24b329dd62bb8cea4e014427acc073884b8916 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 28 Nov 2021 13:49:23 +0100
Subject: [PATCH] Use field with set_move_field to skip and fill move values

When the line is already linked to a move, we must not change the move value
with the default values from the line.

issue10978
review391201002
(grafted from e453761ac7c5a19dd38f97f1b2e4eda2e2b28156)

--HG--
branch : 6.0
---
 move.py | 33 +++++++++++++++++++++------------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/move.py b/move.py
index 017e2c4a40..1d90df7426 100644
--- a/move.py
+++ b/move.py
@@ -1212,25 +1212,34 @@ class Line(ModelSQL, ModelView):
     def create(cls, vlist):
         pool = Pool()
         Move = pool.get('account.move')
-        move = None
+
+        def move_fields():
+            for fname, field in cls._fields.items():
+                if (isinstance(field, fields.Function)
+                        and field.setter == 'set_move_field'):
+                    if fname.startswith('move_'):
+                        fname = fname[5:]
+                    yield fname
+
+        moves = {}
+        context = Transaction().context
         vlist = [x.copy() for x in vlist]
         for vals in vlist:
             if not vals.get('move'):
+                move_values = {}
+                for fname in move_fields():
+                    move_values[fname] = vals.get(fname) or context.get(fname)
+                key = tuple(sorted(move_values.items()))
+                move = moves.get(key)
                 if move is None:
-                    journal_id = (vals.get('journal')
-                            or Transaction().context.get('journal'))
-                    move = Move()
-                    move.period = vals.get('period',
-                        Transaction().context.get('period'))
-                    if move.period:
-                        move.company = move.period.company
-                    move.journal = journal_id
-                    move.date = vals.get('date')
+                    move = Move(**move_values)
                     move.save()
+                    moves[key] = move
                 vals['move'] = move.id
             else:
-                # prevent computation of default date
-                vals.setdefault('date', None)
+                # prevent default value for field with set_move_field
+                for fname in move_fields():
+                    vals.setdefault(fname, None)
         lines = super(Line, cls).create(vlist)
         period_and_journals = set((line.period, line.journal)
             for line in lines)