From 3c3e0903cc493a621becc04db469a4dda2e8412e Mon Sep 17 00:00:00 2001
From: Sergi Almacellas Abellana <sergi@koolpi.com>
Date: Tue, 5 Jul 2016 12:46:40 +0200
Subject: [PATCH] Remove usage of header_view_get and string attribute from
 views

issue2350
review25421002
---
 line.py                              | 8 --------
 view/hours_employee_context_form.xml | 2 +-
 view/hours_employee_graph.xml        | 2 +-
 view/hours_employee_monthly_tree.xml | 2 +-
 view/hours_employee_tree.xml         | 2 +-
 view/hours_employee_weekly_tree.xml  | 2 +-
 view/line_enter_start_form.xml       | 2 +-
 view/line_form.xml                   | 2 +-
 view/line_tree.xml                   | 2 +-
 view/work_context_form.xml           | 2 +-
 view/work_form.xml                   | 2 +-
 view/work_graph.xml                  | 2 +-
 view/work_list.xml                   | 2 +-
 view/work_list_report.xml            | 2 +-
 14 files changed, 13 insertions(+), 21 deletions(-)

diff --git a/line.py b/line.py
index 89470eef64..a72072b490 100644
--- a/line.py
+++ b/line.py
@@ -109,14 +109,6 @@ class Line(ModelSQL, ModelView):
         Date_ = Pool().get('ir.date')
         return Transaction().context.get('date') or Date_.today()
 
-    @classmethod
-    def view_header_get(cls, value, view_type='form'):
-        if not Transaction().context.get('employee'):
-            return value
-        Employee = Pool().get('company.employee')
-        employee = Employee(Transaction().context['employee'])
-        return value + " (" + employee.rec_name + ")"
-
     @classmethod
     def validate(cls, lines):
         super(Line, cls).validate(lines)
diff --git a/view/hours_employee_context_form.xml b/view/hours_employee_context_form.xml
index 0e0a429a62..029f1a04e5 100644
--- a/view/hours_employee_context_form.xml
+++ b/view/hours_employee_context_form.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<form string="Hours per Employee">
+<form>
     <label name="start_date"/>
     <field name="start_date"/>
     <label name="end_date"/>
diff --git a/view/hours_employee_graph.xml b/view/hours_employee_graph.xml
index 324a228e35..dceb3c3888 100644
--- a/view/hours_employee_graph.xml
+++ b/view/hours_employee_graph.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<graph string="Hours per Employee">
+<graph>
     <x>
         <field name="employee"/>
     </x>
diff --git a/view/hours_employee_monthly_tree.xml b/view/hours_employee_monthly_tree.xml
index a881e1acc3..58e92e3eef 100644
--- a/view/hours_employee_monthly_tree.xml
+++ b/view/hours_employee_monthly_tree.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<tree string="Hours per Employee per Month">
+<tree>
     <field name="year"/>
     <field name="month"/>
     <field name="employee"/>
diff --git a/view/hours_employee_tree.xml b/view/hours_employee_tree.xml
index 30701ccb26..045e2dd6e3 100644
--- a/view/hours_employee_tree.xml
+++ b/view/hours_employee_tree.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<tree string="Hours per Employee">
+<tree>
     <field name="employee"/>
     <field name="duration" sum="Duration"/>
 </tree>
diff --git a/view/hours_employee_weekly_tree.xml b/view/hours_employee_weekly_tree.xml
index c8f235669e..38d9c98fcc 100644
--- a/view/hours_employee_weekly_tree.xml
+++ b/view/hours_employee_weekly_tree.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<tree string="Hours per Employee per Week">
+<tree>
     <field name="year"/>
     <field name="week"/>
     <field name="employee"/>
diff --git a/view/line_enter_start_form.xml b/view/line_enter_start_form.xml
index 6bb938299f..b0702056f5 100644
--- a/view/line_enter_start_form.xml
+++ b/view/line_enter_start_form.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<form string="Enter Timesheet">
+<form>
     <label name="employee"/>
     <field name="employee"/>
     <label name="date"/>
diff --git a/view/line_form.xml b/view/line_form.xml
index 3e0df19bb6..5175373a7b 100644
--- a/view/line_form.xml
+++ b/view/line_form.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<form string="Timesheet Line">
+<form>
     <label name="employee"/>
     <field name="employee"/>
     <label name="company"/>
diff --git a/view/line_tree.xml b/view/line_tree.xml
index e9f6b61697..adc12d789f 100644
--- a/view/line_tree.xml
+++ b/view/line_tree.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<tree string="Timesheet Lines" editable="bottom">
+<tree editable="bottom">
     <field name="company"/>
     <field name="employee"/>
     <field name="date"/>
diff --git a/view/work_context_form.xml b/view/work_context_form.xml
index b8e27f84cf..39f1822f77 100644
--- a/view/work_context_form.xml
+++ b/view/work_context_form.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<form string="Work Context">
+<form>
     <label name="from_date"/>
     <field name="from_date"/>
     <label name="to_date"/>
diff --git a/view/work_form.xml b/view/work_form.xml
index 6aec3959e3..97806a41eb 100644
--- a/view/work_form.xml
+++ b/view/work_form.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<form string="Work">
+<form>
     <group id="labels" col="1" xexpand="0" yfill="1">
         <label name="name" xexpand="1" yexpand="1"/>
         <label name="origin" xexpand="1" yexpand="1"/>
diff --git a/view/work_graph.xml b/view/work_graph.xml
index 0e598ba90c..ccdd6a0128 100644
--- a/view/work_graph.xml
+++ b/view/work_graph.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<graph string="Hours per Work" type="pie">
+<graph type="pie">
     <x>
         <field name="name"/>
     </x>
diff --git a/view/work_list.xml b/view/work_list.xml
index d36f7912b3..de815f0fc8 100644
--- a/view/work_list.xml
+++ b/view/work_list.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<tree string="Works">
+<tree>
     <field name="rec_name"/>
     <field name="active" tree_invisible="1"/>
     <field name="origin" tree_invisible="1"/>
diff --git a/view/work_list_report.xml b/view/work_list_report.xml
index 51a93e1361..c331060753 100644
--- a/view/work_list_report.xml
+++ b/view/work_list_report.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
-<tree string="Works">
+<tree>
     <field name="rec_name"/>
     <field name="duration"/>
     <field name="active" tree_invisible="1"/>