From 405d2a7e24dcf055e659bd54812c3535ddac91f9 Mon Sep 17 00:00:00 2001 From: Sergi Almacellas Abellana Date: Wed, 27 Jul 2016 10:09:12 +0200 Subject: [PATCH] Fix antipatern of create/write in loop issue3516 review6901002 --- purchase_request.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/purchase_request.py b/purchase_request.py index 9b8610cb6a..ac4185ac94 100644 --- a/purchase_request.py +++ b/purchase_request.py @@ -142,11 +142,13 @@ class PurchaseRequest: @classmethod def create_requests(cls, new_requests): + to_save = [] for new_req in new_requests: if new_req.supply_date == datetime.date.max: new_req.supply_date = None if new_req.computed_quantity > 0: - new_req.save() + to_save.append(new_req) + cls.save(to_save) @classmethod def compare_requests(cls, new_requests):