From 4d2dd71764c85f3133a090b47522ba43fe4bbcd1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Mon, 16 Feb 2026 19:19:01 +0100
Subject: [PATCH] Enforce invoice type for origin of invoice line

Closes #14611
---
 modules/purchase/invoice.py                |  9 ++++++++-
 modules/purchase/invoice.xml               |  2 +-
 modules/sale/invoice.py                    |  9 ++++++++-
 modules/sale/invoice.xml                   |  2 +-
 modules/sale_rental/account.py             | 16 ++++++++++++++++
 modules/sale_rental/account.xml            |  2 +-
 modules/sale_subscription/invoice.py       | 16 ++++++++++++++++
 modules/sale_subscription/subscription.xml |  2 +-
 8 files changed, 52 insertions(+), 6 deletions(-)

diff --git a/modules/purchase/invoice.py b/modules/purchase/invoice.py
index 10e51c4f7a..90e4fa3222 100644
--- a/modules/purchase/invoice.py
+++ b/modules/purchase/invoice.py
@@ -6,7 +6,7 @@ from trytond.i18n import gettext
 from trytond.model import ModelView, Workflow, fields
 from trytond.model.exceptions import AccessError
 from trytond.pool import Pool, PoolMeta
-from trytond.pyson import Eval
+from trytond.pyson import Bool, Eval, If
 from trytond.tools import cached_property
 from trytond.transaction import Transaction, without_check_access
 
@@ -110,6 +110,13 @@ class InvoiceLine(metaclass=PoolMeta):
             cls.origin.domain = {}
         cls.origin.domain['purchase.line'] = [
             ('type', '=', Eval('type')),
+            If(Bool(Eval('_parent_invoice')),
+                If(Eval('_parent_invoice', {}).get('type') != 'in',
+                    ('id', '=', -1),
+                    ()),
+                If(Eval('invoice_type') != 'in',
+                    ('id', '=', -1),
+                    ())),
             ]
 
     @cached_property
diff --git a/modules/purchase/invoice.xml b/modules/purchase/invoice.xml
index 11ecbf138a..6c745db59d 100644
--- a/modules/purchase/invoice.xml
+++ b/modules/purchase/invoice.xml
@@ -9,7 +9,7 @@ this repository contains the full copyright notices and license terms. -->
             <field name="context"></field>
             <field
                 name="domain"
-                eval="[('purchases.id', 'in', Eval('active_ids', []))]"
+                eval="[('purchases.id', 'in', Eval('active_ids', [])), ('type', '=', 'in')]"
                 pyson="1"/>
         </record>
         <record model="ir.action.keyword"
diff --git a/modules/sale/invoice.py b/modules/sale/invoice.py
index d3fe395218..f0758b65a9 100644
--- a/modules/sale/invoice.py
+++ b/modules/sale/invoice.py
@@ -6,7 +6,7 @@ from trytond.i18n import gettext
 from trytond.model import Workflow, fields
 from trytond.model.exceptions import AccessError
 from trytond.pool import Pool, PoolMeta
-from trytond.pyson import Eval
+from trytond.pyson import Bool, Eval, If
 from trytond.transaction import Transaction, without_check_access
 
 
@@ -118,6 +118,13 @@ class Line(metaclass=PoolMeta):
             cls.origin.domain = {}
         cls.origin.domain['sale.line'] = [
             ('type', '=', Eval('type')),
+            If(Bool(Eval('_parent_invoice')),
+                If(Eval('_parent_invoice', {}).get('type') != 'out',
+                    ('id', '=', -1),
+                    ()),
+                If(Eval('invoice_type') != 'out',
+                    ('id', '=', -1),
+                    ())),
             ]
 
     @fields.depends('origin')
diff --git a/modules/sale/invoice.xml b/modules/sale/invoice.xml
index 7062455e4a..7969295bad 100644
--- a/modules/sale/invoice.xml
+++ b/modules/sale/invoice.xml
@@ -8,7 +8,7 @@ this repository contains the full copyright notices and license terms. -->
             <field name="res_model">account.invoice</field>
             <field
                 name="domain"
-                eval="[('sales.id', 'in', Eval('active_ids', []))]"
+                eval="[('sales.id', 'in', Eval('active_ids', [])), ('type', '=', 'out')]"
                 pyson="1"/>
         </record>
         <record model="ir.action.keyword"
diff --git a/modules/sale_rental/account.py b/modules/sale_rental/account.py
index 8705c4c8c3..486c6b4c6e 100644
--- a/modules/sale_rental/account.py
+++ b/modules/sale_rental/account.py
@@ -3,6 +3,7 @@
 
 from trytond.model import fields
 from trytond.pool import Pool, PoolMeta
+from trytond.pyson import Bool, Eval, If
 from trytond.report import Report
 from trytond.tools import cached_property
 
@@ -34,6 +35,21 @@ class Invoice(metaclass=PoolMeta):
 class InvoiceLine(metaclass=PoolMeta):
     __name__ = 'account.invoice.line'
 
+    @classmethod
+    def __setup__(cls):
+        super().__setup__()
+        if not cls.origin.domain:
+            cls.origin.domain = {}
+        cls.origin.domain['sale.rental.line'] = [
+            If(Bool(Eval('_parent_invoice')),
+                If(Eval('_parent_invoice', {}).get('type') != 'out',
+                    ('id', '=', -1),
+                    ()),
+                If(Eval('invoice_type') != 'out',
+                    ('id', '=', -1),
+                    ())),
+            ]
+
     @fields.depends('product', 'origin')
     def on_change_product(self):
         pool = Pool()
diff --git a/modules/sale_rental/account.xml b/modules/sale_rental/account.xml
index 5fdc22ffef..255fa46c9d 100644
--- a/modules/sale_rental/account.xml
+++ b/modules/sale_rental/account.xml
@@ -8,7 +8,7 @@ this repository contains the full copyright notices and license terms. -->
             <field name="res_model">account.invoice</field>
             <field
                 name="domain"
-                eval="[('sale_rentals.id', 'in', Eval('active_ids', []))]"
+                eval="[('sale_rentals.id', 'in', Eval('active_ids', [])), ('type', '=', 'out')]"
                 pyson="1"/>
         </record>
         <record model="ir.action.keyword" id="act_account_invoice_form_keyword1">
diff --git a/modules/sale_subscription/invoice.py b/modules/sale_subscription/invoice.py
index 77e9906bd6..c5404541ee 100644
--- a/modules/sale_subscription/invoice.py
+++ b/modules/sale_subscription/invoice.py
@@ -1,11 +1,27 @@
 # This file is part of Tryton.  The COPYRIGHT file at the top level of
 # this repository contains the full copyright notices and license terms.
 from trytond.pool import Pool, PoolMeta
+from trytond.pyson import Bool, Eval, If
 
 
 class InvoiceLine(metaclass=PoolMeta):
     __name__ = 'account.invoice.line'
 
+    @classmethod
+    def __setup__(cls):
+        super().__setup__()
+        if not cls.origin.domain:
+            cls.origin.domain = {}
+        cls.origin.domain['sale.subscription.line'] = [
+            If(Bool(Eval('_parent_invoice')),
+                If(Eval('_parent_invoice', {}).get('type') != 'out',
+                    ('id', '=', -1),
+                    ()),
+                If(Eval('invoice_type') != 'out',
+                    ('id', '=', -1),
+                    ())),
+            ]
+
     @property
     def origin_name(self):
         pool = Pool()
diff --git a/modules/sale_subscription/subscription.xml b/modules/sale_subscription/subscription.xml
index 7d539a6ee2..e9d7e997ef 100644
--- a/modules/sale_subscription/subscription.xml
+++ b/modules/sale_subscription/subscription.xml
@@ -218,7 +218,7 @@ this repository contains the full copyright notices and license terms. -->
             <field name="res_model">account.invoice</field>
             <field
                 name="domain"
-                eval="[('lines.origin.subscription.id', 'in', Eval('active_ids'), 'sale.subscription.line')]"
+                eval="[('lines.origin.subscription.id', 'in', Eval('active_ids'), 'sale.subscription.line'), ('type', '=', 'out')]"
                 pyson="1"/>
         </record>
         <record model="ir.action.keyword" id="act_subscription_invoice_relate_keyword1">