From 4f7acf0bbfec2c958230280b77fe157b441c0d5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Thu, 21 Mar 2024 16:55:01 +0100 Subject: [PATCH] Use duck typing to convert single UPS package into a list It seems that UPS has fixed its API such that it always returns a list for PackageResults but it is still better to test the actual result. Closes #13116 --- modules/stock_package_shipping_ups/stock.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/stock_package_shipping_ups/stock.py b/modules/stock_package_shipping_ups/stock.py index 54077c5ff7..9ac87bab6b 100644 --- a/modules/stock_package_shipping_ups/stock.py +++ b/modules/stock_package_shipping_ups/stock.py @@ -213,8 +213,8 @@ class CreateShippingUPS(Wizard): shipment.shipping_reference = ( shipment_results['ShipmentIdentificationNumber']) ups_packages = shipment_results['PackageResults'] - if len(packages) == 1: - # In case only one package is requested UPS returns a dictionnary + if not isinstance(ups_packages, list): + # In case only one package is requested UPS may return a dictionary # instead of a list of one package ups_packages = [ups_packages]