From 5125415da2b928c06c7b9671e2cdf88b0b6dd8f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20=C3=89vrard?= Date: Wed, 13 Feb 2019 16:05:41 +0100 Subject: [PATCH] Allow sao classes to use javascript properties issue8109 review60561002 --- CHANGELOG | 1 + src/sao.js | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG b/CHANGELOG index 9e31041880..3551ef0e54 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,4 @@ +* Allow sao classes to use javascript properties * Improve layout of CSV import/export * Add support for height and width on notebook * Use tab key for tab navigation diff --git a/src/sao.js b/src/sao.js index 3756ccc522..94f7e29072 100644 --- a/src/sao.js +++ b/src/sao.js @@ -125,7 +125,8 @@ var Sao = {}; ClassConstructor._super = Parent.prototype; if (props) { for (var name in props) { - ClassConstructor.prototype[name] = props[name]; + Object.defineProperty(ClassConstructor.prototype, name, + Object.getOwnPropertyDescriptor(props, name)); } } return ClassConstructor;