From 5162fc38bf2b33dd5daaf3503aaa0d5388538429 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Tue, 19 Feb 2008 13:01:37 +0100
Subject: [PATCH] Remove try/except and use query instead

---
 trytond/osv/orm.py | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/trytond/osv/orm.py b/trytond/osv/orm.py
index 00411f483b..2cf8d9aba4 100644
--- a/trytond/osv/orm.py
+++ b/trytond/osv/orm.py
@@ -555,12 +555,15 @@ class ORM(object):
                                         "ON \"%s\" (\"%s\")" % \
                                         (self._table, k, self._table, k))
                             if field.required:
-                                try:
+                                cursor.execute('SELECT id FROM "%s" ' \
+                                        'WHERE "%s" IS NULL' % \
+                                        (self._table, k))
+                                if not cursor.rowcount:
                                     cursor.execute("ALTER TABLE \"%s\" " \
                                             "ALTER COLUMN \"%s\" " \
                                                 "SET NOT NULL" % \
                                                 (self._table, k))
-                                except:
+                                else:
                                     logger.notify_channel('init',
                                             LOG_WARNING,
                                             'Unable to set column %s ' \
@@ -1767,7 +1770,8 @@ class ORM(object):
 
             doc_src = dom.minidom.parseString(src)
             doc_dest = dom.minidom.parseString(inherit)
-            for node2 in doc_dest.childNodes:
+            parent_node = doc_dest.firstChild
+            for node2 in parent_node.childNodes:
                 if not node2.nodeType == node2.ELEMENT_NODE:
                     continue
                 node = _find(doc_src, node2)