From 5172f2dcd4aff559a90efca8d0c725ac13da1963 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sat, 10 Apr 2021 23:46:24 +0200
Subject: [PATCH] Check rule only if _check_access is set and enforce companies
 rule

issue4080
review343891009
---
 sale.xml                     | 10 +++++-----
 tests/test_sale_promotion.py |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/sale.xml b/sale.xml
index a9778b5b4b..4723907788 100644
--- a/sale.xml
+++ b/sale.xml
@@ -53,16 +53,16 @@ this repository contains the full copyright notices and license terms. -->
             <field name="action" ref="act_promotion_relate"/>
         </record>
 
-        <record model="ir.rule.group" id="rule_group_promotion">
-            <field name="name">User in company</field>
+        <record model="ir.rule.group" id="rule_group_promotion_companies">
+            <field name="name">User in companies</field>
             <field name="model" search="[('model', '=', 'sale.promotion')]"/>
             <field name="global_p" eval="True"/>
         </record>
-        <record model="ir.rule" id="rule_promotion1">
+        <record model="ir.rule" id="rule_promotion_companies">
             <field name="domain"
-                eval="[('company', '=', Eval('user', {}).get('company', None))]"
+                eval="[('company', 'in', Eval('companies', []))]"
                 pyson="1"/>
-            <field name="rule_group" ref="rule_group_promotion"/>
+            <field name="rule_group" ref="rule_group_promotion_companies"/>
         </record>
 
         <record model="ir.model.access" id="access_promotion">
diff --git a/tests/test_sale_promotion.py b/tests/test_sale_promotion.py
index 2f2fbfa015..f01f7f04d2 100644
--- a/tests/test_sale_promotion.py
+++ b/tests/test_sale_promotion.py
@@ -7,10 +7,10 @@ from trytond.tests.test_tryton import ModuleTestCase
 from trytond.tests.test_tryton import doctest_teardown
 from trytond.tests.test_tryton import doctest_checker
 
-from trytond.modules.company.tests import CompanyMultiValueTestMixin
+from trytond.modules.company.tests import CompanyTestMixin
 
 
-class SalePromotionTestCase(CompanyMultiValueTestMixin, ModuleTestCase):
+class SalePromotionTestCase(CompanyTestMixin, ModuleTestCase):
     'Test Sale Promotion module'
     module = 'sale_promotion'