From 586054ad2ca352aed2e615c9ce7111bd456b0fc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Sun, 1 Mar 2020 12:33:54 +0100 Subject: [PATCH] Fix flake8 errors and warnings We add the flake8 configuration used so we ensure everyone uses the same. We remove the usage of __all__ for non public API. When possible, we rationalize the class name according to its __name__ and module. issue9082 review297061002 --- .flake8 | 2 ++ product.py | 3 --- setup.py | 7 ++++--- stock.py | 7 ------- 4 files changed, 6 insertions(+), 13 deletions(-) create mode 100644 .flake8 diff --git a/.flake8 b/.flake8 new file mode 100644 index 0000000000..bb03d08a82 --- /dev/null +++ b/.flake8 @@ -0,0 +1,2 @@ +[flake8] +ignore=E123,E124,E126,E128,W503 diff --git a/product.py b/product.py index e6c5cfd90f..3fde6b9e63 100644 --- a/product.py +++ b/product.py @@ -6,9 +6,6 @@ from trytond.pool import PoolMeta from trytond.pyson import Eval -__all__ = ['Template', 'Product'] - - class Template(metaclass=PoolMeta): __name__ = 'product.template' diff --git a/setup.py b/setup.py index a26d0a138f..afafedbaaf 100755 --- a/setup.py +++ b/setup.py @@ -80,8 +80,8 @@ setup(name=name, keywords='tryton stock lot unit serial', package_dir={'trytond.modules.stock_lot_unit': '.'}, packages=( - ['trytond.modules.stock_lot_unit'] + - ['trytond.modules.stock_lot_unit.%s' % p for p in find_packages()] + ['trytond.modules.stock_lot_unit'] + + ['trytond.modules.stock_lot_unit.%s' % p for p in find_packages()] ), package_data={ 'trytond.modules.stock_lot_unit': (info.get('xml', []) @@ -94,7 +94,8 @@ setup(name=name, 'Framework :: Tryton', 'Intended Audience :: Developers', 'Intended Audience :: Manufacturing', - 'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)', + 'License :: OSI Approved :: ' + 'GNU General Public License v3 or later (GPLv3+)', 'Natural Language :: Bulgarian', 'Natural Language :: Catalan', 'Natural Language :: Chinese (Simplified)', diff --git a/stock.py b/stock.py index a9fc804cbc..6504eca5b7 100644 --- a/stock.py +++ b/stock.py @@ -9,13 +9,6 @@ from trytond.pyson import Eval, Bool from .exceptions import LotUnitQuantityError -__all__ = [ - 'Lot', 'Move', 'Inventory', 'InventoryCount', - 'ShipmentIn', 'ShipmentInReturn', - 'ShipmentOut', 'ShipmentOutReturn', - 'Production', - ] - class Lot(metaclass=PoolMeta): __name__ = 'stock.lot'