From 5c834f2e1db3235df919b7666647fbe0c73bb85b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Sat, 1 Sep 2018 01:02:03 +0200 Subject: [PATCH] Improve ModelStorage.copy * Allow callable in copy default * Support dotted notation in copy default * Use setdefault in copy * Copy default when needed * Do not set default state in copy * Use callable and dotted notation in copy default issue5576 issue7648 review72291002 --- purchase.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/purchase.py b/purchase.py index 3e918c90cb..8d820e43be 100644 --- a/purchase.py +++ b/purchase.py @@ -67,8 +67,9 @@ class Purchase(metaclass=PoolMeta): def copy(cls, purchases, default=None): if default is None: default = {} - default = default.copy() - default['invoice_lines_ignored'] = None + else: + default = default.copy() + default.setdefault('invoice_lines_ignored', None) return super(Purchase, cls).copy(purchases, default=default)