From 5d92401f3df6330d19f7c14e2a44761d7bd18842 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Sun, 21 Mar 2021 16:09:13 +0100 Subject: [PATCH] Replace cursor fetchall by iteration over cursor issue5817 review335831003 --- opportunity.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/opportunity.py b/opportunity.py index 33e251dc88..b5dc32fc70 100644 --- a/opportunity.py +++ b/opportunity.py @@ -134,7 +134,9 @@ class SaleOpportunity( def __register__(cls, module_name): pool = Pool() Sale = pool.get('sale.sale') - cursor = Transaction().connection.cursor() + transaction = Transaction() + cursor = transaction.connection.cursor() + update = transaction.connection.cursor() sql_table = cls.__table__() sale = Sale.__table__() @@ -154,8 +156,8 @@ class SaleOpportunity( cursor.execute(*sql_table.select( sql_table.id, sql_table.sale, where=sql_table.sale != Null)) - for id_, sale_id in cursor.fetchall(): - cursor.execute(*sale.update( + for id_, sale_id in cursor: + update.execute(*sale.update( columns=[sale.origin], values=['%s,%s' % (cls.__name__, id_)], where=sale.id == sale_id))