From 6144237ef69bda80a35fc2e3ff3886192d96328d Mon Sep 17 00:00:00 2001 From: Maxime Richez Date: Mon, 24 Oct 2016 16:15:28 +0200 Subject: [PATCH] Re-fix TypeError on drop_column for SQLite Fixing bad interpretation on the value (tuple) when iterating on the dictionary in previous changeset 9c2eb1b04df8 issue2647 review33491002 --- trytond/backend/sqlite/table.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/trytond/backend/sqlite/table.py b/trytond/backend/sqlite/table.py index d64ced566c..044217edfa 100644 --- a/trytond/backend/sqlite/table.py +++ b/trytond/backend/sqlite/table.py @@ -299,10 +299,11 @@ class TableHandler(TableHandlerInterface): logger.warning('Unable to drop column: Error renaming ' 'table %s to temp!', self.table_name) new_table = TableHandler(self._model, history=self.history) - for name, column in self._columns.iteritems(): + for name, (notnull, hasdef, size, typname) \ + in self._columns.iteritems(): if name != column_name: - new_table.add_raw_column(name, column['typname'], True, - field_size=column['size']) + new_table.add_raw_column(name, typname, True, + field_size=size) columns_name = [x for x in new_table._columns.keys()] cursor.execute(('INSERT INTO "%s" (' + ','.join('"%s"' % c for c in columns_name) +