From 62c3c8c37c8a7d508b2ab08899a312ef36ff2e59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Sun, 1 Mar 2020 12:33:53 +0100 Subject: [PATCH] Fix flake8 errors and warnings We add the flake8 configuration used so we ensure everyone uses the same. We remove the usage of __all__ for non public API. When possible, we rationalize the class name according to its __name__ and module. issue9082 review297061002 --- .flake8 | 2 ++ sale.py | 2 +- setup.py | 8 +++++--- tests/__init__.py | 2 +- 4 files changed, 9 insertions(+), 5 deletions(-) create mode 100644 .flake8 diff --git a/.flake8 b/.flake8 new file mode 100644 index 0000000000..bb03d08a82 --- /dev/null +++ b/.flake8 @@ -0,0 +1,2 @@ +[flake8] +ignore=E123,E124,E126,E128,W503 diff --git a/sale.py b/sale.py index ef8dfd43e1..098ab9403c 100644 --- a/sale.py +++ b/sale.py @@ -45,7 +45,7 @@ class Line(metaclass=PoolMeta): product_customers = list(self.product.product_customer_used( **self._get_product_customer_pattern())) if len(product_customers) == 1: - self.product_customer, = product_customers + self.product_customer, = product_customers elif (self.product_customer and self.product_customer not in product_customers): self.product_customer = None diff --git a/setup.py b/setup.py index 8cdbe79f9d..49c9153ef0 100755 --- a/setup.py +++ b/setup.py @@ -80,8 +80,9 @@ setup(name=name, keywords='tryton sale product customer', package_dir={'trytond.modules.sale_product_customer': '.'}, packages=( - ['trytond.modules.sale_product_customer'] + - ['trytond.modules.sale_product_customer.%s' % p for p in find_packages()] + ['trytond.modules.sale_product_customer'] + + ['trytond.modules.sale_product_customer.%s' % p + for p in find_packages()] ), package_data={ 'trytond.modules.sale_product_customer': (info.get('xml', []) @@ -95,7 +96,8 @@ setup(name=name, 'Intended Audience :: Developers', 'Intended Audience :: Financial and Insurance Industry', 'Intended Audience :: Legal Industry', - 'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)', + 'License :: OSI Approved :: ' + 'GNU General Public License v3 or later (GPLv3+)', 'Natural Language :: Bulgarian', 'Natural Language :: Catalan', 'Natural Language :: Chinese (Simplified)', diff --git a/tests/__init__.py b/tests/__init__.py index 60290a2b78..070079cc97 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -2,7 +2,7 @@ # this repository contains the full copyright notices and license terms. try: - from trytond.modules.sale_product_customer.tests.test_sale_product_customer import suite + from trytond.modules.sale_product_customer.tests.test_sale_product_customer import suite # noqa: E501 except ImportError: from .test_sale_product_customer import suite