From 6cc13fd3d41d16f62156343cf2eda00f148f8254 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Wed, 2 Jan 2019 18:53:18 +0100 Subject: [PATCH] Do not recycle first record as product result The value of the field of the first record, which is edited in the list, will be lost. Because the editable widget is started before the search pop-up and it override the new default value with its content when the pop-up is closed. So we can not reuse record create before the pop-up. issue7941 review49681002 --- tryton/gui/window/view_form/view/form_gtk/one2many.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tryton/gui/window/view_form/view/form_gtk/one2many.py b/tryton/gui/window/view_form/view/form_gtk/one2many.py index abb9550526..2029f942b0 100644 --- a/tryton/gui/window/view_form/view/form_gtk/one2many.py +++ b/tryton/gui/window/view_form/view/form_gtk/one2many.py @@ -382,18 +382,14 @@ class One2Many(Widget): win_search.screen.search_filter() win_search.show() - def make_product(first=first): + def make_product(): + self.screen.group.remove(first, remove=True) if not product: - self.screen.group.remove(first, remove=True) return fields = list(product.keys()) for values in itertools.product(*list(product.values())): - if first: - record = first - first = None - else: - record = self.screen.new(default=False) + record = self.screen.new(default=False) default_value = default.copy() for field, value in zip(fields, values): id_, rec_name = value