From 70449bd4d8f68168b2bdd1d1bf7bcd152d2b2c5c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Val=C3=A9ry?= <raphael42@gmail.com>
Date: Wed, 11 Aug 2021 18:02:25 +0200
Subject: [PATCH] Do not remove record from the looped list when setting list
 ids

issue10638
review358561002
---
 src/model.js | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/model.js b/src/model.js
index 89d1b85145..c5cba73ac5 100644
--- a/src/model.js
+++ b/src/model.js
@@ -2165,12 +2165,17 @@
                 }
             }
             if (mode == 'list ids') {
+                var records_to_remove = [];
                 for (var i = 0, len = group.length; i < len; i++) {
                     var old_record = group[i];
                     if (!~value.indexOf(old_record.id)) {
-                        group.remove(old_record, true, true, false, false);
+                        records_to_remove.push(old_record);
                     }
                 }
+                for (i = 0, len = records_to_remove.length; i < len; i++) {
+                    var record_to_remove = records_to_remove[i];
+                    group.remove(record_to_remove, true, true, false, false);
+                }
                 group.load(value, modified || default_);
             } else {
                 value.forEach(function(vals) {