From 721ae8dc69158788bd8edc4a5d6ea9485f563f84 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Mon, 13 Mar 2023 22:53:44 +0100 Subject: [PATCH] Rename product lead times to production lead times #12133 --- modules/production/CHANGELOG | 1 + modules/production/product.py | 4 ++-- modules/production/production.py | 2 +- modules/production/tests/test_module.py | 4 ++-- modules/production/view/product_form.xml | 2 +- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git a/modules/production/CHANGELOG b/modules/production/CHANGELOG index 06bd85559b..60bdf87e8e 100644 --- a/modules/production/CHANGELOG +++ b/modules/production/CHANGELOG @@ -1,3 +1,4 @@ +* Rename product lead times to production lead times * Remove support for Python 3.7 * Add support for Python 3.11 * Create lot for output product when needed diff --git a/modules/production/product.py b/modules/production/product.py index e52f3ff897..6f499ab1a0 100644 --- a/modules/production/product.py +++ b/modules/production/product.py @@ -39,7 +39,7 @@ class Product(metaclass=PoolMeta): states={ 'invisible': ~Eval('producible') }) - lead_times = fields.One2Many('production.lead_time', + production_lead_times = fields.One2Many('production.lead_time', 'product', 'Lead Times', order=[('sequence', 'ASC'), ('id', 'ASC')], states={ 'invisible': ~Eval('producible'), @@ -73,7 +73,7 @@ class Product(metaclass=PoolMeta): else: default = default.copy() default.setdefault('boms', None) - default.setdefault('lead_times', None) + default.setdefault('production_lead_times', None) return super(Product, cls).copy(products, default=default) diff --git a/modules/production/production.py b/modules/production/production.py index d88761ec46..4cbe59cb92 100644 --- a/modules/production/production.py +++ b/modules/production/production.py @@ -322,7 +322,7 @@ class Production(ShipmentAssignMixin, Workflow, ModelSQL, ModelView): pattern = {} if self.product: pattern.setdefault('bom', self.bom.id if self.bom else None) - for line in self.product.lead_times: + for line in self.product.production_lead_times: if line.match(pattern): return line.lead_time or timedelta() return timedelta() diff --git a/modules/production/tests/test_module.py b/modules/production/tests/test_module.py index 2327b5fd29..94c49433f1 100644 --- a/modules/production/tests/test_module.py +++ b/modules/production/tests/test_module.py @@ -21,7 +21,7 @@ class ProductionTestCase(CompanyTestMixin, ModuleTestCase): date = datetime.date(2016, 11, 26) product = Product() - product.lead_times = [] + product.production_lead_times = [] production = Production() production.planned_date = date production.product = product @@ -29,7 +29,7 @@ class ProductionTestCase(CompanyTestMixin, ModuleTestCase): self.assertEqual(production.on_change_with_planned_start_date(), date) lead_time = LeadTime(bom=None, lead_time=None) - product.lead_times = [lead_time] + product.production_lead_times = [lead_time] self.assertEqual(production.on_change_with_planned_start_date(), date) lead_time.lead_time = datetime.timedelta(1) diff --git a/modules/production/view/product_form.xml b/modules/production/view/product_form.xml index 88cbdec510..251b3c1d06 100644 --- a/modules/production/view/product_form.xml +++ b/modules/production/view/product_form.xml @@ -4,6 +4,6 @@ this repository contains the full copyright notices and license terms. --> - +