From 7402eb03ec8a0b718d33dbda26a839bbd4a33004 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Sun, 1 Mar 2020 12:33:51 +0100 Subject: [PATCH] Fix flake8 errors and warnings We add the flake8 configuration used so we ensure everyone uses the same. We remove the usage of __all__ for non public API. When possible, we rationalize the class name according to its __name__ and module. issue9082 review297061002 --- .flake8 | 2 ++ account.py | 3 --- setup.py | 7 ++++--- tests/__init__.py | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) create mode 100644 .flake8 diff --git a/.flake8 b/.flake8 new file mode 100644 index 0000000000..bb03d08a82 --- /dev/null +++ b/.flake8 @@ -0,0 +1,2 @@ +[flake8] +ignore=E123,E124,E126,E128,W503 diff --git a/account.py b/account.py index f8c4d11f92..12e94b9d25 100644 --- a/account.py +++ b/account.py @@ -12,9 +12,6 @@ from trytond.sendmail import sendmail_transactional, SMTPDataManager from trytond.transaction import Transaction from trytond.wizard import StateTransition -__all__ = ['Configuration', 'DunningLevel', 'ProcessDunning', 'Dunning', - 'DunningEmailLog'] - class Configuration(metaclass=PoolMeta): __name__ = 'account.configuration' diff --git a/setup.py b/setup.py index 6b42aee9b1..a540e9ef21 100755 --- a/setup.py +++ b/setup.py @@ -79,8 +79,8 @@ setup(name=name, keywords='tryton account dunning email', package_dir={'trytond.modules.account_dunning_email': '.'}, packages=( - ['trytond.modules.account_dunning_email'] + - ['trytond.modules.account_dunning_email.%s' % p + ['trytond.modules.account_dunning_email'] + + ['trytond.modules.account_dunning_email.%s' % p for p in find_packages()] ), package_data={ @@ -95,7 +95,8 @@ setup(name=name, 'Intended Audience :: Developers', 'Intended Audience :: Financial and Insurance Industry', 'Intended Audience :: Legal Industry', - 'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)', + 'License :: OSI Approved :: ' + 'GNU General Public License v3 or later (GPLv3+)', 'Natural Language :: Bulgarian', 'Natural Language :: Catalan', 'Natural Language :: Czech', diff --git a/tests/__init__.py b/tests/__init__.py index ba4242750c..af3f5a3b3d 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -2,7 +2,7 @@ # this repository contains the full copyright notices and license terms. try: - from trytond.modules.account_dunning_email.tests.test_account_dunning_email import suite + from trytond.modules.account_dunning_email.tests.test_account_dunning_email import suite # noqa: E501 except ImportError: from .test_account_dunning_email import suite