From 79010a403ca8a6d0cc55f8f1ec8fb4ab19a9b87b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 1 Mar 2020 12:33:54 +0100
Subject: [PATCH] Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
---
 .flake8           | 2 ++
 product.py        | 2 --
 production.py     | 1 -
 setup.py          | 7 ++++---
 stock.py          | 2 --
 tests/__init__.py | 2 +-
 6 files changed, 7 insertions(+), 9 deletions(-)
 create mode 100644 .flake8

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..bb03d08a82
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff --git a/product.py b/product.py
index 9264e1888f..71706f7da5 100644
--- a/product.py
+++ b/product.py
@@ -4,8 +4,6 @@ from datetime import timedelta
 
 from trytond.pool import Pool, PoolMeta
 
-__all__ = ['Product']
-
 
 class Product(metaclass=PoolMeta):
     __name__ = 'product.product'
diff --git a/production.py b/production.py
index 87dcf374d0..6854efb1ca 100644
--- a/production.py
+++ b/production.py
@@ -8,7 +8,6 @@ from trytond.pool import Pool, PoolMeta
 from trytond.transaction import Transaction
 from trytond.tools import grouped_slice
 
-__all__ = ['Configuration', 'ConfigurationSupplyPeriod', 'Production']
 supply_period = fields.TimeDelta("Supply Period")
 
 
diff --git a/setup.py b/setup.py
index 2ca3faeb84..4f2acbab7b 100755
--- a/setup.py
+++ b/setup.py
@@ -79,8 +79,8 @@ setup(name=name,
     keywords='tryton stock supply production',
     package_dir={'trytond.modules.stock_supply_production': '.'},
     packages=(
-        ['trytond.modules.stock_supply_production'] +
-        ['trytond.modules.stock_supply_production.%s' % p
+        ['trytond.modules.stock_supply_production']
+        + ['trytond.modules.stock_supply_production.%s' % p
             for p in find_packages()]
         ),
     package_data={
@@ -95,7 +95,8 @@ setup(name=name,
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
         'Intended Audience :: Manufacturing',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',
diff --git a/stock.py b/stock.py
index fbe244b71c..b7bc045d42 100644
--- a/stock.py
+++ b/stock.py
@@ -9,8 +9,6 @@ from trytond.wizard import StateAction
 
 from trytond.modules.stock_supply.exceptions import SupplyWarning
 
-__all__ = ['OrderPoint', 'LocationLeadTime', 'StockSupply']
-
 
 class OrderPoint(metaclass=PoolMeta):
     __name__ = 'stock.order_point'
diff --git a/tests/__init__.py b/tests/__init__.py
index 5dd993e493..01f746ff4e 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.stock_supply_production.tests.test_stock_supply_production import suite
+    from trytond.modules.stock_supply_production.tests.test_stock_supply_production import suite  # noqa: E501
 except ImportError:
     from .test_stock_supply_production import suite