From 7ffb3b587dc856f6ff2f743abc569ea97af96d78 Mon Sep 17 00:00:00 2001 From: Sergi Almacellas Abellana Date: Tue, 26 Apr 2016 12:39:27 +0200 Subject: [PATCH] Fix NoneType error when comparing purchases without warehouse issue5478 review19231002 --- purchase_request.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/purchase_request.py b/purchase_request.py index 33edd87de0..66090b61f3 100644 --- a/purchase_request.py +++ b/purchase_request.py @@ -161,8 +161,8 @@ class PurchaseRequest: for request in requests: pline = request.purchase_line # Skip incoherent request - if request.product.id != pline.product.id or \ - request.warehouse.id != pline.purchase.warehouse.id: + if (request.product != pline.product + or request.warehouse != pline.purchase.warehouse): continue # Take smallest amount between request and purchase line pline_qty = Uom.compute_qty(pline.unit, pline.quantity,