From 83aa7909e3ddff2a3673f06ba0b026d83870a8a2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 1 Mar 2020 12:33:51 +0100
Subject: [PATCH] Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
---
 .flake8           | 2 ++
 __init__.py       | 6 +++---
 invoice.py        | 2 --
 setup.py          | 7 ++++---
 tests/__init__.py | 2 +-
 5 files changed, 10 insertions(+), 9 deletions(-)
 create mode 100644 .flake8

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..bb03d08a82
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff --git a/__init__.py b/__init__.py
index 32bc3ef5b3..1347d596d2 100644
--- a/__init__.py
+++ b/__init__.py
@@ -2,11 +2,11 @@
 # this repository contains the full copyright notices and license terms.
 
 from trytond.pool import Pool
-from .invoice import *
+from . import invoice
 
 
 def register():
     Pool.register(
-        Invoice,
-        InvoiceLine,
+        invoice.Invoice,
+        invoice.InvoiceLine,
         module='account_invoice_line_standalone', type_='model')
diff --git a/invoice.py b/invoice.py
index bdaab9eb84..546381d959 100644
--- a/invoice.py
+++ b/invoice.py
@@ -4,8 +4,6 @@ from trytond.pyson import Eval
 from trytond.transaction import Transaction
 from trytond.pool import PoolMeta
 
-__all__ = ['Invoice', 'InvoiceLine']
-
 
 class Invoice(metaclass=PoolMeta):
     __name__ = 'account.invoice'
diff --git a/setup.py b/setup.py
index 60c166acdc..1a50f8c248 100755
--- a/setup.py
+++ b/setup.py
@@ -79,8 +79,8 @@ setup(name=name,
     keywords='tryton account standalone invoice line',
     package_dir={'trytond.modules.account_invoice_line_standalone': '.'},
     packages=(
-        ['trytond.modules.account_invoice_line_standalone'] +
-        ['trytond.modules.account_invoice_line_standalone.%s' % p
+        ['trytond.modules.account_invoice_line_standalone']
+        + ['trytond.modules.account_invoice_line_standalone.%s' % p
             for p in find_packages()]
         ),
     package_data={
@@ -94,7 +94,8 @@ setup(name=name,
         'Intended Audience :: Developers',
         'Intended Audience :: Legal Industry',
         'Intended Audience :: Manufacturing',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',
diff --git a/tests/__init__.py b/tests/__init__.py
index 44d3ca6cb8..acda3a2c6a 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.account_invoice_line_standalone.tests.test_account_invoice_line_standalone import suite
+    from trytond.modules.account_invoice_line_standalone.tests.test_account_invoice_line_standalone import suite  # noqa: E501
 except ImportError:
     from .test_account_invoice_line_standalone import suite