From 88c784b5993fdf4bf7ce298365d3cdc1943133ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Thu, 1 Apr 2010 12:56:56 +0200 Subject: [PATCH] Don't allow empty vat_number if vat_country is set for issue1468 --- CHANGELOG | 1 + party.py | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 58df7d2c28..a6db617bdd 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,4 @@ +* Don't allow empty vat_number if vat_country is set * Use model singleton to define which party sequence to use * Improve search_rec_name of category to take care of separator diff --git a/party.py b/party.py index 2a6b03403c..58ac835148 100644 --- a/party.py +++ b/party.py @@ -34,7 +34,10 @@ class Party(ModelSQL, ModelView): code_length = fields.Integer('Code Length', select=1, readonly=True) lang = fields.Many2One("ir.lang", 'Language', states=STATES) vat_number = fields.Char('VAT Number', help="Value Added Tax number", - states=STATES) + states={ + 'readonly': Not(Bool(Eval('active'))), + 'required': Bool(Eval('vat_country')), + }) vat_country = fields.Selection(VAT_COUNTRIES, 'VAT Country', states=STATES, help="Setting VAT country will enable validation of the VAT number.", translate=False) @@ -206,7 +209,7 @@ class Party(ModelSQL, ModelView): for party in self.browse(cursor, user, ids): vat_number = party.vat_number - if not (vat_number and party.vat_country): + if not party.vat_country: continue if not getattr(vatnumber, 'check_vat_' + \