From 8c3345db1762ca3d10711f4cedbdf7f1d0ad0934 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Thu, 5 Dec 2024 20:27:29 +0100
Subject: [PATCH] Display coupons as form on promotion

Closes #13738
---
 modules/sale_promotion/view/promotion_form.xml        | 11 ++++++-----
 modules/sale_promotion_coupon/view/promotion_form.xml |  6 ++++--
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/modules/sale_promotion/view/promotion_form.xml b/modules/sale_promotion/view/promotion_form.xml
index a10bb20a6a..18597340c1 100644
--- a/modules/sale_promotion/view/promotion_form.xml
+++ b/modules/sale_promotion/view/promotion_form.xml
@@ -33,10 +33,11 @@ this repository contains the full copyright notices and license terms. -->
     <field name="quantity"/>
     <label name="unit"/>
     <field name="unit"/>
-    <newline/>
 
-    <group id="categories_products" col="-1" colspan="6" yexpand="1">
-        <field name="categories"/>
-        <field name="products" view_ids="product.product_view_tree_simple"/>
-    </group>
+    <notebook colspan="6">
+        <page id="products" string="Products">
+            <field name="categories" colspan="2"/>
+            <field name="products" colspan="2" view_ids="product.product_view_tree_simple"/>
+        </page>
+    </notebook>
 </form>
diff --git a/modules/sale_promotion_coupon/view/promotion_form.xml b/modules/sale_promotion_coupon/view/promotion_form.xml
index 1310dad85a..ec7ec42f2f 100644
--- a/modules/sale_promotion_coupon/view/promotion_form.xml
+++ b/modules/sale_promotion_coupon/view/promotion_form.xml
@@ -2,7 +2,9 @@
 <!-- This file is part of Tryton.  The COPYRIGHT file at the top level of
 this repository contains the full copyright notices and license terms. -->
 <data>
-    <xpath expr="//field[@name='products']" position="after">
-        <field name="coupons"/>
+    <xpath expr="//page[@id='products']" position="after">
+        <page name="coupons">
+            <field name="coupons" mode="form,tree"/>
+        </page>
     </xpath>
 </data>