From 8dee983fc8a2e5c7e0456832187e30a9c37f0ed5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 22 Jun 2014 16:57:10 +0200
Subject: [PATCH] Fix initialisation of CellRendererBinary properties

The definition are wrong for boolean type and editable is not initialised in
__init__ which may crash if the property is not changed before rendering.

issue4002
review10381002
---
 tryton/common/cellrendererbinary.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tryton/common/cellrendererbinary.py b/tryton/common/cellrendererbinary.py
index 792593d091..a4e96c7e1b 100644
--- a/tryton/common/cellrendererbinary.py
+++ b/tryton/common/cellrendererbinary.py
@@ -10,9 +10,9 @@ BUTTON_SPACING = 2
 
 class CellRendererBinary(gtk.GenericCellRenderer):
     __gproperties__ = {
-        'visible': (gobject.TYPE_INT, 'Visible', 'Visible', 0, 10, 0,
+        'visible': (gobject.TYPE_BOOLEAN, 'Visible', 'Visible', True,
             gobject.PARAM_READWRITE),
-        'editable': (gobject.TYPE_INT, 'Editable', 'Editable', 0, 10, 0,
+        'editable': (gobject.TYPE_BOOLEAN, 'Editable', 'Editable', False,
             gobject.PARAM_READWRITE),
         'size': (gobject.TYPE_STRING, 'Size', 'Size', '',
             gobject.PARAM_READWRITE),
@@ -31,6 +31,7 @@ class CellRendererBinary(gtk.GenericCellRenderer):
     def __init__(self, use_filename):
         self.__gobject_init__()
         self.visible = True
+        self.editable = False
         self.set_property('mode', gtk.CELL_RENDERER_MODE_EDITABLE)
         self.use_filename = use_filename
         if use_filename: