From 8dfb25155faa3ead8bc80d9ee1485d0ab94d5381 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 1 Mar 2020 12:33:53 +0100
Subject: [PATCH] Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
---
 .flake8           | 2 ++
 __init__.py       | 4 ++--
 sale.py           | 3 ---
 setup.py          | 8 +++++---
 tests/__init__.py | 2 +-
 5 files changed, 10 insertions(+), 9 deletions(-)
 create mode 100644 .flake8

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..bb03d08a82
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff --git a/__init__.py b/__init__.py
index 9af0cc2891..3b8c59f3ee 100644
--- a/__init__.py
+++ b/__init__.py
@@ -2,10 +2,10 @@
 # this repository contains the full copyright notices and license terms.
 
 from trytond.pool import Pool
-from .sale import *
+from . import sale
 
 
 def register():
     Pool.register(
-        Sale,
+        sale.Sale,
         module='sale_stock_quantity', type_='model')
diff --git a/sale.py b/sale.py
index 17002ebc20..8e4e92d146 100644
--- a/sale.py
+++ b/sale.py
@@ -12,9 +12,6 @@ from trytond.tools import grouped_slice
 from .exceptions import StockQuantityError, StockQuantityWarning
 
 
-__all__ = ['Sale']
-
-
 class Sale(metaclass=PoolMeta):
     __name__ = 'sale.sale'
 
diff --git a/setup.py b/setup.py
index e3ecd04c50..7523a02fa2 100755
--- a/setup.py
+++ b/setup.py
@@ -82,8 +82,9 @@ setup(name=name,
     keywords='tryton sale stock',
     package_dir={'trytond.modules.sale_stock_quantity': '.'},
     packages=(
-        ['trytond.modules.sale_stock_quantity'] +
-        ['trytond.modules.sale_stock_quantity.%s' % p for p in find_packages()]
+        ['trytond.modules.sale_stock_quantity']
+        + ['trytond.modules.sale_stock_quantity.%s' % p
+            for p in find_packages()]
         ),
     package_data={
         'trytond.modules.sale_stock_quantity': (info.get('xml', [])
@@ -98,7 +99,8 @@ setup(name=name,
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
         'Intended Audience :: Manufacturing',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',
diff --git a/tests/__init__.py b/tests/__init__.py
index 4f718e7919..8d02d2b574 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.sale_stock_quantity.tests.test_sale_stock_quantity import suite
+    from trytond.modules.sale_stock_quantity.tests.test_sale_stock_quantity import suite  # noqa: E501
 except ImportError:
     from .test_sale_stock_quantity import suite