From 9abcd9257ee03ecfc96d0744a42dc10f64f2c6dc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 1 Mar 2020 12:33:51 +0100
Subject: [PATCH] Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
---
 .flake8           | 2 ++
 account.py        | 2 --
 party.py          | 2 --
 setup.py          | 7 ++++---
 tests/__init__.py | 2 +-
 5 files changed, 7 insertions(+), 8 deletions(-)
 create mode 100644 .flake8

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..bb03d08a82
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff --git a/account.py b/account.py
index 0c7d9fee74..ff2996d16a 100644
--- a/account.py
+++ b/account.py
@@ -6,8 +6,6 @@ from trytond.model import ModelView, Workflow, fields
 from trytond.pool import PoolMeta
 from trytond.transaction import Transaction
 
-__all__ = ['Invoice']
-
 
 class Invoice(metaclass=PoolMeta):
     __name__ = 'account.invoice'
diff --git a/party.py b/party.py
index 24aa33f095..63a664fd01 100644
--- a/party.py
+++ b/party.py
@@ -2,8 +2,6 @@
 # this repository contains the full copyright notices and license terms.
 from trytond.pool import PoolMeta
 
-__all__ = ['Party', 'Address']
-
 
 class Party(metaclass=PoolMeta):
     __name__ = 'party.party'
diff --git a/setup.py b/setup.py
index e71bea4344..273a57ddf9 100755
--- a/setup.py
+++ b/setup.py
@@ -78,8 +78,8 @@ setup(name=name,
     keywords='tryton account invoice history',
     package_dir={'trytond.modules.account_invoice_history': '.'},
     packages=(
-        ['trytond.modules.account_invoice_history'] +
-        ['trytond.modules.account_invoice_history.%s' % p
+        ['trytond.modules.account_invoice_history']
+        + ['trytond.modules.account_invoice_history.%s' % p
             for p in find_packages()]
         ),
     package_data={
@@ -93,7 +93,8 @@ setup(name=name,
         'Intended Audience :: Developers',
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',
diff --git a/tests/__init__.py b/tests/__init__.py
index c7057fa363..160ae7315b 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.account_invoice_history.tests.test_account_invoice_history import suite
+    from trytond.modules.account_invoice_history.tests.test_account_invoice_history import suite  # noqa: E501
 except ImportError:
     from .test_account_invoice_history import suite