From 9effe04fdf91e4b6fe867a3fd88091c83d192730 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Tue, 21 Dec 2021 23:24:05 +0100
Subject: [PATCH] Do not stringify binary data

For the identify only the size matter to refresh the display.
And to detect change, we can compare the Uint8Array between them or with the
size.

issue10994
review360581002
(grafted from 1d6b2b4544620646f5d8307d8acee5c762d6ab19)

--HG--
branch : 6.0
---
 src/model.js | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/model.js b/src/model.js
index 39b34f1605..5f998bd8e2 100644
--- a/src/model.js
+++ b/src/model.js
@@ -1416,7 +1416,11 @@
                 Object.keys(this._values).reduce(function(values, name) {
                     var field = this.model.fields[name];
                     if (field) {
-                        values[name] = field.get(this);
+                        if (field instanceof Sao.field.Binary) {
+                            values[name] = field.get_size(this);
+                        } else {
+                            values[name] = field.get(this);
+                        }
                     }
                     return values;
                 }.bind(this), {}));
@@ -1549,12 +1553,14 @@
             }
             return value;
         },
+        _has_changed: function(previous, value) {
+            // Use stringify to compare object instance like Number for Decimal
+            return JSON.stringify(previous) != JSON.stringify(value);
+        },
         set_client: function(record, value, force_change) {
             var previous_value = this.get(record);
             this.set(record, value);
-            // Use stringify to compare object instance like Number for Decimal
-            if (JSON.stringify(previous_value) !=
-                JSON.stringify(this.get(record))) {
+            if (this._has_changed(previous_value, this.get(record))) {
                 record._changed[this.name] = true;
                 this.changed(record);
                 record.validate(null, true, false, true);
@@ -2692,6 +2698,9 @@
 
     Sao.field.Binary = Sao.class_(Sao.field.Field, {
         _default: null,
+        _has_changed: function(previous, value) {
+            return previous != value;
+        },
         get_size: function(record) {
             var data = record._values[this.name] || 0;
             if (data instanceof Uint8Array) {