From a2ef3287509fa2dcda2911b5cc9e79c9baec039a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Thu, 25 Aug 2016 19:12:43 +0200 Subject: [PATCH] Fix Screen.domain_parser to filter only field in view and remove duplicate 'id' addition issue5815 review30441002 --- src/screen.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/screen.js b/src/screen.js index d94862be63..8dd4e2db15 100644 --- a/src/screen.js +++ b/src/screen.js @@ -1270,15 +1270,16 @@ // Filter only fields in XML view var xml_view = jQuery(jQuery.parseXML(view_tree.arch)); var xml_fields = xml_view.find('tree').children() - .filter(function(node) { + .filter(function(i, node) { return node.tagName == 'field'; - }).map(function(node) { + }).map(function(i, node) { return node.getAttribute('name'); }); var dom_fields = {}; - xml_fields.each(function(name) { + xml_fields.each(function(k, name) { dom_fields[name] = fields[name]; }); + fields = dom_fields; } // Add common fields @@ -1307,13 +1308,6 @@ } } }); - if (!('id' in fields)) { - fields.id = { - 'string': Sao.i18n.gettext('ID'), - 'name': 'id', - 'type': 'integer' - }; - } var context = jQuery.extend({}, this.model.session.context,