From a7c4269ad5aa667bf79e32f6239188b343ea3652 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Sun, 1 Mar 2020 12:33:51 +0100 Subject: [PATCH] Fix flake8 errors and warnings We add the flake8 configuration used so we ensure everyone uses the same. We remove the usage of __all__ for non public API. When possible, we rationalize the class name according to its __name__ and module. issue9082 review297061002 --- .flake8 | 2 ++ setup.py | 7 ++++--- statement.py | 2 -- tests/__init__.py | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) create mode 100644 .flake8 diff --git a/.flake8 b/.flake8 new file mode 100644 index 0000000000..bb03d08a82 --- /dev/null +++ b/.flake8 @@ -0,0 +1,2 @@ +[flake8] +ignore=E123,E124,E126,E128,W503 diff --git a/setup.py b/setup.py index fdfcd81da2..9484e0be76 100755 --- a/setup.py +++ b/setup.py @@ -79,8 +79,8 @@ setup(name=name, keywords='tryton account statement AEB 43', package_dir={'trytond.modules.account_statement_aeb43': '.'}, packages=( - ['trytond.modules.account_statement_aeb43'] + - ['trytond.modules.account_statement_aeb43.%s' % p + ['trytond.modules.account_statement_aeb43'] + + ['trytond.modules.account_statement_aeb43.%s' % p for p in find_packages()] ), package_data={ @@ -95,7 +95,8 @@ setup(name=name, 'Intended Audience :: Developers', 'Intended Audience :: Financial and Insurance Industry', 'Intended Audience :: Legal Industry', - 'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)', + 'License :: OSI Approved :: ' + 'GNU General Public License v3 or later (GPLv3+)', 'Natural Language :: Bulgarian', 'Natural Language :: Catalan', 'Natural Language :: Chinese (Simplified)', diff --git a/statement.py b/statement.py index e4f1f3f145..9cfa52e3bf 100644 --- a/statement.py +++ b/statement.py @@ -10,8 +10,6 @@ from trytond.pool import Pool, PoolMeta from trytond.modules.account_statement.exceptions import ImportStatementError -__all__ = ['ImportStatementStart', 'ImportStatement'] - class ImportStatementStart(metaclass=PoolMeta): __name__ = 'account.statement.import.start' diff --git a/tests/__init__.py b/tests/__init__.py index a1eaf7990d..2a5484334f 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -2,7 +2,7 @@ # this repository contains the full copyright notices and license terms. try: - from trytond.modules.account_statement_aeb43.tests.test_account_statement_aeb43 import suite + from trytond.modules.account_statement_aeb43.tests.test_account_statement_aeb43 import suite # noqa: E501 except ImportError: from .test_account_statement_aeb43 import suite