From af8e3466599a20265cef8bbd0d30432f1150e2e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Sun, 21 Mar 2021 16:09:13 +0100 Subject: [PATCH] Replace cursor fetchall by iteration over cursor issue5817 review335831003 --- dunning.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/dunning.py b/dunning.py index 77ba5fec80..45a6d6e1b5 100644 --- a/dunning.py +++ b/dunning.py @@ -37,7 +37,9 @@ class Level(sequence_ordered(), ModelSQL, ModelView): @classmethod def __register__(cls, module_name): - cursor = Transaction().connection.cursor() + transaction = Transaction() + cursor = transaction.connection.cursor() + update = transaction.connection.cursor() table = cls.__table_handler__(module_name) sql_table = cls.__table__() @@ -47,9 +49,9 @@ class Level(sequence_ordered(), ModelSQL, ModelView): if table.column_exist('days'): cursor.execute(*sql_table.select(sql_table.id, sql_table.days, where=sql_table.days != Null)) - for id_, days in cursor.fetchall(): + for id_, days in cursor: overdue = datetime.timedelta(days) - cursor.execute(*sql_table.update( + update.execute(*sql_table.update( [sql_table.overdue], [overdue], where=sql_table.id == id_))