From afd411fd78dea0e139efce355d9f419c6fae20e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Sat, 5 Nov 2022 09:51:17 +0100 Subject: [PATCH] Do not expand boolean PYSON when using __and__ and __or__ It is not expected that the left operand is modified by such operations. issue11836 review418551003 --- proteus/pyson.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/proteus/pyson.py b/proteus/pyson.py index 5d919a495b..496f151bc6 100644 --- a/proteus/pyson.py +++ b/proteus/pyson.py @@ -32,8 +32,7 @@ class PYSON(object): other = Bool(other) if (isinstance(self, And) and not isinstance(self, Or)): - self._statements.append(other) - return self + return And(*self._statements, other) if self.types() != {bool}: return And(Bool(self), other) else: @@ -46,8 +45,7 @@ class PYSON(object): and other.types() != {bool}): other = Bool(other) if isinstance(self, Or): - self._statements.append(other) - return self + return Or(*self._statements, other) if self.types() != {bool}: return Or(Bool(self), other) else: