From b02c49c30d9bc4e794f59aadc5bf905b3dcfdcc6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Thu, 30 Oct 2025 01:00:12 +0100 Subject: [PATCH] Use line's get_move_product_types to require incoterm Closes #14332 --HG-- branch : 7.0 --- modules/incoterm/purchase.py | 4 +++- modules/incoterm/sale.py | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/modules/incoterm/purchase.py b/modules/incoterm/purchase.py index e87f90fbea..d13f98c88a 100644 --- a/modules/incoterm/purchase.py +++ b/modules/incoterm/purchase.py @@ -32,7 +32,9 @@ class Purchase(IncotermAvailableMixin, metaclass=PoolMeta): super().check_for_quotation() if not self.incoterm and self._incoterm_required: for line in self.lines: - if line.product and line.product.type in {'goods', 'assets'}: + if (line.product + and line.product.type in line.get_move_product_types() + ): raise PurchaseQuotationError( gettext('incoterm' '.msg_purchase_incoterm_required_for_quotation', diff --git a/modules/incoterm/sale.py b/modules/incoterm/sale.py index b732484e01..cea9f590f2 100644 --- a/modules/incoterm/sale.py +++ b/modules/incoterm/sale.py @@ -51,7 +51,9 @@ class Sale(IncotermAvailableMixin, metaclass=PoolMeta): super().check_for_quotation() if not self.incoterm and self._incoterm_required: for line in self.lines: - if line.product and line.product.type in {'goods', 'assets'}: + if (line.product + and line.product.type in line.get_move_product_types() + ): raise SaleQuotationError( gettext('incoterm' '.msg_sale_incoterm_required_for_quotation',