From b8b2bf12d1279d2ca5b3fbcfcda977f12b917804 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Mon, 2 Mar 2015 23:40:37 +0100 Subject: [PATCH] Improve logging issue4458 review11781002 --- res.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/res.py b/res.py index 66e14c98fe..6f6a79b597 100644 --- a/res.py +++ b/res.py @@ -107,8 +107,8 @@ class User: if cls.ldap_search_user(login, con, attrs=[]): find = True break - except ldap.LDAPError, e: - logger.error('LDAPError: %s' % str(e)) + except ldap.LDAPError: + logger.error('LDAPError when checking password', exc_info=True) if find: cls.raise_user_error('set_passwd_ldap_user', (login,)) @@ -149,8 +149,9 @@ class User: del values['password'] else: cls.raise_user_error('wrong_password') - except ldap.LDAPError, e: - logger.error('LDAPError: %s' % str(e)) + except ldap.LDAPError: + logger.error('LDAPError when setting preferences', + exc_info=True) super(User, cls).set_preferences(values, old_password=old_password) @classmethod @@ -177,6 +178,6 @@ class User: 'login': login, }]) return user.id - except ldap.LDAPError, e: - logger.error('LDAPError: %s' % str(e)) + except ldap.LDAPError: + logger.error('LDAPError when login', exc_info=True) return super(User, cls).get_login(login, password)