From bab234389f72158bcaa07dd590dd7001875ff38c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 10 Mar 2024 00:31:44 +0100
Subject: [PATCH] Activate no-self-assign rule of eslint

---
 sao/eslint.config.mjs | 1 -
 sao/src/screen.js     | 3 ++-
 sao/src/tab.js        | 7 +------
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/sao/eslint.config.mjs b/sao/eslint.config.mjs
index 89aa93bf85..88d42ba532 100644
--- a/sao/eslint.config.mjs
+++ b/sao/eslint.config.mjs
@@ -21,7 +21,6 @@ export default [
             },
         },
         rules: {
-            "no-self-assign": "off",
             "no-unexpected-multiline": "off",
             "no-unused-vars": "off",
             "no-useless-escape": "off",
diff --git a/sao/src/screen.js b/sao/src/screen.js
index 626d583f89..cf9366c528 100644
--- a/sao/src/screen.js
+++ b/sao/src/screen.js
@@ -1350,7 +1350,8 @@
             }
             return jQuery.when.apply(jQuery, deferreds).then(
                 () => this.set_tree_state().then(() => {
-                    this.current_record = this.current_record;
+                    var record = this.current_record
+                    this.current_record = record;
                     // set_cursor must be called after set_tree_state because
                     // set_tree_state redraws the tree
                     if (set_cursor) {
diff --git a/sao/src/tab.js b/sao/src/tab.js
index 27b8fd1c91..6ee394e3bf 100644
--- a/sao/src/tab.js
+++ b/sao/src/tab.js
@@ -1660,12 +1660,7 @@
             this.board.reload();
         },
         record_message: function() {
-            var i, len;
-            var action;
-
-            len = this.board.actions.length;
-            for (i = 0, len=len; i < len; i++) {
-                action = this.board.actions[i];
+            for (const action of this.board.actions) {
                 action.update_domain(this.board.actions);
             }
         },