From bd2189127bab46b7f2d7f17a0b119a2b8a907320 Mon Sep 17 00:00:00 2001
From: Sergi Almacellas Abellana <sergi@koolpi.com>
Date: Thu, 1 Mar 2018 12:42:04 +0100
Subject: [PATCH] Register all buttons are registered in ir.model.button

issue6389
review36621002
---
 invoice.xml           |  8 ++++++++
 view/invoice_form.xml | 16 +++++-----------
 view/invoice_tree.xml |  9 ++++-----
 3 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/invoice.xml b/invoice.xml
index 46422a4f05..544e00366f 100644
--- a/invoice.xml
+++ b/invoice.xml
@@ -150,6 +150,9 @@ this repository contains the full copyright notices and license terms. -->
 
         <record model="ir.model.button" id="invoice_cancel_button">
             <field name="name">cancel</field>
+            <field name="string">Cancel</field>
+            <field name="confirm">Are you sure to cancel the invoice?</field>
+            <field name="help">Cancel the invoice</field>
             <field name="model" search="[('model', '=', 'account.invoice')]"/>
         </record>
         <record model="ir.model.button-res.group"
@@ -160,6 +163,7 @@ this repository contains the full copyright notices and license terms. -->
 
         <record model="ir.model.button" id="invoice_draft_button">
             <field name="name">draft</field>
+            <field name="string">Draft</field>
             <field name="model" search="[('model', '=', 'account.invoice')]"/>
         </record>
         <record model="ir.model.button-res.group"
@@ -170,6 +174,8 @@ this repository contains the full copyright notices and license terms. -->
 
         <record model="ir.model.button" id="invoice_validate_button">
             <field name="name">validate_invoice</field>
+            <field name="string">Validate</field>
+            <field name="help">Also known as Pro Forma</field>
             <field name="model" search="[('model', '=', 'account.invoice')]"/>
         </record>
         <record model="ir.model.button-res.group"
@@ -180,6 +186,7 @@ this repository contains the full copyright notices and license terms. -->
 
         <record model="ir.model.button" id="invoice_post_button">
             <field name="name">post</field>
+            <field name="string">Post</field>
             <field name="model" search="[('model', '=', 'account.invoice')]"/>
         </record>
         <record model="ir.model.button-res.group"
@@ -189,6 +196,7 @@ this repository contains the full copyright notices and license terms. -->
         </record>
         <record model="ir.model.button" id="invoice_pay_button">
             <field name="name">pay</field>
+            <field name="string">Pay</field>
             <field name="model" search="[('model', '=', 'account.invoice')]"/>
         </record>
         <record model="ir.model.button-res.group"
diff --git a/view/invoice_form.xml b/view/invoice_form.xml
index 17f7ee7bae..88c88441bc 100644
--- a/view/invoice_form.xml
+++ b/view/invoice_form.xml
@@ -47,17 +47,11 @@ this repository contains the full copyright notices and license terms. -->
                         <field name="total_amount" xalign="1.0" xexpand="0"/>
                     </group>
                     <group col="-1" colspan="4" id="buttons">
-                        <button name="cancel" string="Cancel"
-                            icon="tryton-cancel"
-                            confirm="Are you sure to cancel the invoice?"/>
-                        <button name="draft" string="Draft"
-                            icon="tryton-go-previous"/>
-                        <button name="validate_invoice"
-                            string="Validate"
-                            help="Also known as Pro Forma"
-                            icon="tryton-go-next"/>
-                        <button name="post" string="Post" icon="tryton-ok"/>
-                        <button name="pay" string="Pay" icon="tryton-go-next"/>
+                        <button name="cancel" icon="tryton-cancel"/>
+                        <button name="draft" icon="tryton-go-previous"/>
+                        <button name="validate_invoice" icon="tryton-go-next"/>
+                        <button name="post" icon="tryton-ok"/>
+                        <button name="pay" icon="tryton-go-next"/>
                     </group>
                 </group>
             </group>
diff --git a/view/invoice_tree.xml b/view/invoice_tree.xml
index 9add3f31b1..33414b2fd3 100644
--- a/view/invoice_tree.xml
+++ b/view/invoice_tree.xml
@@ -14,9 +14,8 @@ this repository contains the full copyright notices and license terms. -->
     <field name="state"/>
     <field name="amount_to_pay_today"/>
     <field name="description"/>
-    <button name="cancel" string="Cancel" tree_invisible="1"
-        confirm="Are you sure to cancel the invoice?"/>
-    <button name="draft" string="Draft" tree_invisible="1"/>
-    <button name="validate_invoice" string="Validate" tree_invisible="1"/>
-    <button name="post" string="Post" tree_invisible="1"/>
+    <button name="cancel" tree_invisible="1"/>
+    <button name="draft" tree_invisible="1"/>
+    <button name="validate_invoice" tree_invisible="1"/>
+    <button name="post" tree_invisible="1"/>
 </tree>