From 5006e5e70d91b741f8acf9d3dadcb896e7933277 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20Tr=C3=A9segnie?= Date: Thu, 19 Apr 2012 19:40:39 +0200 Subject: [PATCH] Add length check for SIREN and SIRET issue2342 review333001 --- address.py | 5 +++-- party.py | 6 ++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/address.py b/address.py index 1c04cb88e0..49b3b37220 100644 --- a/address.py +++ b/address.py @@ -36,8 +36,9 @@ class Address(Model): Check validity of SIRET ''' for address in self.browse(ids): - if address.siret and not luhn.validate(address.siret): - return False + if address.siret: + if len(address.siret) != 14 or not luhn.validate(address.siret): + return False return True Address() diff --git a/party.py b/party.py index b541b7d72f..7a4eaa829b 100644 --- a/party.py +++ b/party.py @@ -26,8 +26,10 @@ class Party(Model): Check validity of SIREN ''' for party in self.browse(ids): - if party.siren and not luhn.validate(party.siren): - return False + if party.siren: + if len(party.siren) != 9 or not luhn.validate(party.siren): + return False + print party.addresses return True Party()