From bf0170cec564fd20fc068d2f63080e26fd76626b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 4 Oct 2015 19:41:59 +0200
Subject: [PATCH] Fix icon in button

Use img with the same height as the button line-height

review21441003
---
 src/common.js | 13 +++++++------
 src/sao.less  |  6 ++++++
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/src/common.js b/src/common.js
index f4270725bb..2850c1031f 100644
--- a/src/common.js
+++ b/src/common.js
@@ -715,21 +715,22 @@
             this.el = jQuery('<button/>', {
                 'class': 'btn btn-default',
                 'type': 'button'
-            }).text(attributes.string || '')
-            .append(jQuery('<span/>', {
-                'class': 'glyphicon',
+            });
+            this.icon = jQuery('<img/>', {
+                'class': 'icon',
                 'aria-hidden': true
-            }));
+            }).appendTo(this.el);
+            this.el.append(attributes.string || '');
             this.set_icon(attributes.icon);
         },
         set_icon: function(icon_name) {
             if (!icon_name) {
+                this.icon.attr('src', '');
                 return;
             }
             var prm = Sao.common.ICONFACTORY.register_icon(icon_name);
             prm.done(function(url) {
-                this.el.children('.glyphicon').css(
-                    'background-image', 'url("' + url + '")');
+                this.icon.attr('src', url);
             }.bind(this));
         },
         set_state: function(record) {
diff --git a/src/sao.less b/src/sao.less
index 6305199537..bcaf321b68 100644
--- a/src/sao.less
+++ b/src/sao.less
@@ -29,6 +29,12 @@ input[type='color'] {
     }
 }
 
+button {
+   & img.icon {
+       height: unit(@line-height-base, em);
+   }
+}
+
 .treeview {
     & > table.tree {
         width: 100%;