From c06b56d9a467e0e64ba415f0808e80d4669cdd8f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 1 Mar 2020 12:33:53 +0100
Subject: [PATCH] Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
---
 .flake8           | 2 ++
 party.py          | 2 --
 sale.py           | 2 --
 setup.py          | 7 ++++---
 tests/__init__.py | 2 +-
 5 files changed, 7 insertions(+), 8 deletions(-)
 create mode 100644 .flake8

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..bb03d08a82
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff --git a/party.py b/party.py
index aed90beefb..3a5ef12315 100644
--- a/party.py
+++ b/party.py
@@ -5,8 +5,6 @@ from decimal import Decimal
 from trytond.pool import Pool, PoolMeta
 from trytond.transaction import Transaction
 
-__all__ = ['Party']
-
 
 class Party(metaclass=PoolMeta):
     __name__ = 'party.party'
diff --git a/sale.py b/sale.py
index fb78eda359..fbc0a869b5 100644
--- a/sale.py
+++ b/sale.py
@@ -3,8 +3,6 @@
 from trytond.model import ModelView, Workflow
 from trytond.pool import PoolMeta
 
-__all__ = ['Sale']
-
 
 class Sale(metaclass=PoolMeta):
     __name__ = 'sale.sale'
diff --git a/setup.py b/setup.py
index 54b75141ab..8c7c162451 100755
--- a/setup.py
+++ b/setup.py
@@ -78,8 +78,8 @@ setup(name=name,
     keywords='tryton sale credit limit',
     package_dir={'trytond.modules.sale_credit_limit': '.'},
     packages=(
-        ['trytond.modules.sale_credit_limit'] +
-        ['trytond.modules.sale_credit_limit.%s' % p for p in find_packages()]
+        ['trytond.modules.sale_credit_limit']
+        + ['trytond.modules.sale_credit_limit.%s' % p for p in find_packages()]
         ),
     package_data={
         'trytond.modules.sale_credit_limit': (info.get('xml', [])
@@ -92,7 +92,8 @@ setup(name=name,
         'Intended Audience :: Developers',
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',
diff --git a/tests/__init__.py b/tests/__init__.py
index 333baa07cd..7cfaf1e3a4 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.sale_credit_limit.tests.test_sale_credit_limit import suite
+    from trytond.modules.sale_credit_limit.tests.test_sale_credit_limit import suite  # noqa: E501
 except ImportError:
     from .test_sale_credit_limit import suite