From c169d22f966e39e522a6bfc41ce9980bcb9d2f32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Krier?= Date: Thu, 21 Aug 2025 17:49:46 +0200 Subject: [PATCH] Update Shopify payment even if the captured amount is zero Closes #14181 --- modules/web_shop_shopify/account.py | 2 +- modules/web_shop_shopify/tests/scenario_web_shop_shopify.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/web_shop_shopify/account.py b/modules/web_shop_shopify/account.py index c86f44c309..5be78b3e9f 100644 --- a/modules/web_shop_shopify/account.py +++ b/modules/web_shop_shopify/account.py @@ -96,7 +96,7 @@ class Payment(IdentifierMixin, metaclass=PoolMeta): to_save = [] for payment in id2payments.values(): - if captured[payment] and payment.amount != captured[payment]: + if payment.amount != captured[payment]: payment.amount = captured[payment] to_save.append(payment) cls.proceed(to_save) diff --git a/modules/web_shop_shopify/tests/scenario_web_shop_shopify.rst b/modules/web_shop_shopify/tests/scenario_web_shop_shopify.rst index 909520aff4..f7e5ddca84 100644 --- a/modules/web_shop_shopify/tests/scenario_web_shop_shopify.rst +++ b/modules/web_shop_shopify/tests/scenario_web_shop_shopify.rst @@ -503,7 +503,7 @@ Run fetch order:: >>> payment.state 'processing' >>> payment.amount - Decimal('258.98') + Decimal('0') >>> assertEqual(sale.carrier, carrier) >>> sale.state 'quotation'