From c47d34f46fcdab9bb436760d482fe520e2c807a5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Krier?= <ced@b2ck.com>
Date: Sun, 1 Mar 2020 12:33:51 +0100
Subject: [PATCH] Fix flake8 errors and warnings

We add the flake8 configuration used so we ensure everyone uses the same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__ and module.

issue9082
review297061002
---
 .flake8           | 2 ++
 __init__.py       | 4 ++--
 account.py        | 2 --
 setup.py          | 9 +++++----
 tests/__init__.py | 2 +-
 5 files changed, 10 insertions(+), 9 deletions(-)
 create mode 100644 .flake8

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000000..bb03d08a82
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff --git a/__init__.py b/__init__.py
index b650e8e4db..dedf15bce1 100644
--- a/__init__.py
+++ b/__init__.py
@@ -2,10 +2,10 @@
 # this repository contains the full copyright notices and license terms.
 
 from trytond.pool import Pool
-from .account import *
+from . import account
 
 
 def register():
     Pool.register(
-        LandedCost,
+        account.LandedCost,
         module='account_stock_landed_cost_weight', type_='model')
diff --git a/account.py b/account.py
index de14a5b8b3..fad77ba0b2 100644
--- a/account.py
+++ b/account.py
@@ -4,8 +4,6 @@ from decimal import Decimal
 
 from trytond.pool import PoolMeta
 
-__all__ = ['LandedCost']
-
 
 class LandedCost(metaclass=PoolMeta):
     __name__ = 'account.landed_cost'
diff --git a/setup.py b/setup.py
index fecbcc1ee9..2ea62405e0 100755
--- a/setup.py
+++ b/setup.py
@@ -80,8 +80,8 @@ setup(name=name,
     keywords='tryton account stock valuation landed cost weight',
     package_dir={'trytond.modules.account_stock_landed_cost_weight': '.'},
     packages=(
-        ['trytond.modules.account_stock_landed_cost_weight'] +
-        ['trytond.modules.account_stock_landed_cost_weight.%s' % p
+        ['trytond.modules.account_stock_landed_cost_weight']
+        + ['trytond.modules.account_stock_landed_cost_weight.%s' % p
             for p in find_packages()]
         ),
     package_data={
@@ -96,7 +96,8 @@ setup(name=name,
         'Intended Audience :: Developers',
         'Intended Audience :: Financial and Insurance Industry',
         'Intended Audience :: Legal Industry',
-        'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)',
+        'License :: OSI Approved :: '
+        'GNU General Public License v3 or later (GPLv3+)',
         'Natural Language :: Bulgarian',
         'Natural Language :: Catalan',
         'Natural Language :: Chinese (Simplified)',
@@ -134,7 +135,7 @@ setup(name=name,
     entry_points="""
     [trytond.modules]
     account_stock_landed_cost_weight = trytond.modules.account_stock_landed_cost_weight
-    """,
+    """,  # noqa: E501
     test_suite='tests',
     test_loader='trytond.test_loader:Loader',
     tests_require=tests_require,
diff --git a/tests/__init__.py b/tests/__init__.py
index 811693ec2e..1b6e8985a5 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -2,7 +2,7 @@
 # this repository contains the full copyright notices and license terms.
 
 try:
-    from trytond.modules.account_stock_landed_cost_weight.tests.test_account_stock_landed_cost_weight import suite
+    from trytond.modules.account_stock_landed_cost_weight.tests.test_account_stock_landed_cost_weight import suite  # noqa: E501
 except ImportError:
     from .test_account_stock_landed_cost_weight import suite